Bug #10702


Plugin Package tag appearing incorrectly at top of plugins.php

Added by Boone Gorges about 4 years ago. Updated about 4 years ago.

Priority name:
Category name:
Plugin Packages
Target version:
Start date:
Due date:
% Done:


Estimated time:
Deployment actions:


At I'm seeing a "Plugin Packages: Multimedia" graphic appearing at the top of the list, not attached to any plugin. Is this maybe due to a plugin being filtered from the list? See screenshot.


Screenshot_2018-11-14_16-43-13.png (116 KB) Screenshot_2018-11-14_16-43-13.png Boone Gorges, 2018-11-14 11:44 AM
Actions #2

Updated by Raymond Hoh about 4 years ago

Hi Boone, can you see if you pulled the latest changes from the cac-plugin-packages submodule on production?

I fixed this in cac-plugin-packages here -

And the cac-plugin-packages submodule for the cac repo is pinned to a more recent commit.

Update - Looks like production is using the latest changeset. I can't duplicate this on my local set up. Will look into this some more.

Actions #3

Updated by Raymond Hoh about 4 years ago

  • Status changed from New to Resolved

Fixed in

The problem was attempting to inject the "Plugin packages" line by matching the table row's data-slug attribute.

For example, the YouTube Embed Plus plugin has the following table row markup:

<tr class="inactive" data-slug="youtube" data-plugin="youtube-embed-plus/youtube.php">

I was expecting youtube-embed-plus to be the data-slug, but the API uses youtube, which is weird and not what I was expecting. I fixed this by doing a prefix match against the data-plugin attribute, which contains the correct slug I'm looking for.

Pushed as a hotfix to production.

Actions #4

Updated by Boone Gorges about 4 years ago

Awesome - thanks, Ray!


Also available in: Atom PDF