Project

General

Profile

Bug #10772

can't create groups

Added by Marilyn Weber 5 months ago. Updated 5 months ago.

Status:
Resolved
Priority name:
Normal
Assignee:
-
Category name:
Groups (misc)
Target version:
Start date:
2018-12-03
Due date:
% Done:

0%

Estimated time:

Description

I've had two ZD reports that attemps to create a new group has ended with the message "Your new group was deleted", and no such group is created. It's happening when I try as well. Yikes!

del.JPG (64 KB) del.JPG Marilyn Weber, 2018-12-03 11:56 AM

History

#1 Updated by Boone Gorges 5 months ago

  • Category name set to Groups (misc)
  • Status changed from New to Reporter Feedback
  • Target version set to 1.14.2

Thanks for the report. This bug was introduced in https://github.com/cuny-academic-commons/cac/commit/51e192197ea2c4b45792143be32c0c6824ec373d as part of #4350. The bail conditions for the post handler were too broad: they checked for the presence of a nonce, but the nonce was in fact printed on multiple steps of the group creation process. There was no specific check that the Cancel button had in fact been clicked. I've added that check in https://github.com/cuny-academic-commons/cac/commit/b070c32c28e17519e4c993453960aebab1f050a0 and deployed to the production site.

Marilyn, can you please verify the fix?

#2 Updated by Marilyn Weber 5 months ago

All fixed! Speedy and impressive, thanks!

#3 Updated by Boone Gorges 5 months ago

  • Status changed from Reporter Feedback to Resolved

Thanks for confirming!

#4 Updated by Raymond Hoh 5 months ago

The bail conditions for the post handler were too broad: they checked for the presence of a nonce, but the nonce was in fact printed on multiple steps of the group creation process. There was no specific check that the Cancel button had in fact been clicked.

Ugh, thanks for fixing my mistake, Boone!

#5 Updated by Boone Gorges 5 months ago

Glad we caught it :)

Also available in: Atom PDF