Project

General

Profile

Support #10792

sexgenlabs site - Elementor + Glossary + creative commons license widget

Added by scott voth 5 months ago. Updated 4 months ago.

Status:
Resolved
Priority name:
Normal
Assignee:
Category name:
WordPress Plugins
Target version:
Start date:
2018-12-05
Due date:
% Done:

0%

Estimated time:

Description

The sexgenlabs site is using the Glossary plugin. They didn't like the license text appearing on each of their glossary terms, so I fixed that with some CSS. No problem. But they also have a page that lists all Glossary terms and definitions - https://sexgenlabs.commons.gc.cuny.edu/glossary-page/ This page is built with Elementor. For some reason, the definition of each term is concatenated with "This entry is licensed under a Creative Commons CC0 1.0 Universal Public Domain Dedication license." (no image, just the text)

"Glossary" documentation is pretty sketchy on how to get both the term and definition to show up - so I can see why they resorted to Elementor. I've looked at this for a while and don't see how to hide the offending text, since it is a concatenated string.

Any ideas? Is there a way to shut off the creative license widget?

History

#1 Updated by Boone Gorges 5 months ago

  • Assignee set to Raymond Hoh
  • Target version set to 1.14.2

It looks like this is coming from the cac-creative-commons plugin.

Ray, maybe we should be more selective about when and how the post-footer is added? Maybe only for a whitelist of post types? And maybe only when is_single()? Any other ideas?

#2 Updated by Raymond Hoh 5 months ago

  • Status changed from New to Staged for Production Release

What I originally intended was for the license to show up in the post loop on archive pages as well. I didn't really think things through with other post types.

So I think it makes sense to only expose this to singular blog posts at this time and no other post types. I've made the change here:
https://github.com/cuny-academic-commons/cac/commit/4bdfa14ba1518fb7ffe3595a39e33ff82ce2a69c

Let me know if you want me to deploy the fix to production.

Do we also want the page post type to also have the license capability?

#3 Updated by Boone Gorges 5 months ago

Thanks, Ray. I think that this conservative change is a good one for now. In the future, maybe we can have some sort of per-item or per-post-type toggle.

Scott, this change will go into effect after our next scheduled maintenance release, which is on Tuesday the 11th.

#4 Updated by Boone Gorges 5 months ago

Sorry, missed the question about the 'page' post type - I'd say yeah, go ahead and add it. Thank you!

#5 Updated by Raymond Hoh 5 months ago

Added the 'page' post type in https://github.com/cuny-academic-commons/cac/commit/762f670080846090532d03329ce878a7e35f413a.

In the future, maybe we can have some sort of per-item or per-post-type toggle.

Yeah, I'm thinking there may be cases where an author might want to omit a license for a post altogether. Sounds like a good feature request.

#6 Updated by scott voth 5 months ago

Thanks guys!

#7 Updated by Boone Gorges 4 months ago

  • Status changed from Staged for Production Release to Resolved

Also available in: Atom PDF