Project

General

Profile

Feature #10978

Use centralized campus data to build all campus lists

Added by Boone Gorges 3 months ago. Updated 2 months ago.

Status:
Resolved
Priority name:
Normal
Assignee:
Category name:
-
Target version:
Start date:
2019-01-17
Due date:
% Done:

0%

Estimated time:

Description

See #10975. All campus lists - particularly in Positions widget and on Members sidebar - should be built by cac_get_cuny_campuses().


Related issues

Related to CUNY Academic Commons - Bug #10975: New Community College -> Guttman Community CollegeResolved2019-01-16

Related to CUNY Academic Commons - Feature #11087: Add additional campuses to network campus listNew2019-02-12

Related to CUNY Academic Commons - Bug #11268: College list not showing up during registrationResolved2019-03-26

History

#1 Updated by Boone Gorges 3 months ago

  • Related to Bug #10975: New Community College -> Guttman Community College added

#2 Updated by Boone Gorges 3 months ago

  • Target version changed from 1.14.5 to 1.14.6

#3 Updated by Boone Gorges 2 months ago

  • Assignee set to Boone Gorges

I've made the necessary changes to the Positions widget:
https://github.com/cuny-academic-commons/cac/commit/fa68a776a728d1f4739e659a8a87824096696025
https://github.com/cuny-academic-commons/cac/commit/c93d88e169db9f7b0f74769c400aa3006517388b
https://github.com/cuny-academic-commons/cac/commit/f26bfb7499313c12b7c6f4d85b482eb5eb3396cb

There are some mismatches between the old, hardcoded Colleges and the new, dynamic ones. In the following cases, the wording of the college name has changed. Markup on the front-end is generated dynamically, so the only necessary change at the time of deployment is to change the relevant taxonomy term 'name' field on the following:

'CUNY School of Public Health' => 'CUNY Graduate School of Public Health and Health Policy'
'NYC College of Technology' => 'New York City College of Technology'
'Stella and Charles Guttman Community College' => 'Guttman Community College'

In addition, the old hardcoded list had a couple of entries that don't appear on the new list. I think it's worth discussing whether these items (with the exception of "Non-CUNY") should be added to the more general Campuses list - or, perhaps, only in certain contexts? For the time being, I've simply added them to the list in the context of the Positions widget:

'*Non-CUNY',
'CUNY Central',
'Sophie Davis School of Biomedical Education',
'Teacher Academy',

#4 Updated by Boone Gorges 2 months ago

  • Status changed from New to Staged for Production Release

I've migrated the College list on the /members/ filter interface to the new system in https://github.com/cuny-academic-commons/cac/commit/2ae5684ab7827db89ce8e668bf187d34d3b3131d. Previously, those filters were rewritten to use the cacap_positions_college taxonomy for querying users, which means that changing the term names as described in the previous comment will be all that's required at the database level to reflect the current changes.

#5 Updated by Boone Gorges 2 months ago

  • Status changed from Staged for Production Release to Resolved

#6 Updated by Matt Gold 2 months ago

Thanks, Boone. I see no reason not to add those four entries to the more general Campuses list

#7 Updated by Boone Gorges 2 months ago

Thanks. I'm going to open a new ticket to discuss it.

#8 Updated by Boone Gorges 2 months ago

  • Related to Feature #11087: Add additional campuses to network campus list added

#9 Updated by Boone Gorges 29 days ago

  • Related to Bug #11268: College list not showing up during registration added

Also available in: Atom PDF