Project

General

Profile

Bug #11174

Email notifications of spammed comment on groupblog

Added by Matt Gold over 2 years ago. Updated over 2 years ago.

Status:
Resolved
Priority name:
High
Assignee:
Category name:
Email Notifications
Target version:
Start date:
2019-02-26
Due date:
% Done:

0%

Estimated time:

Description

I received four email notifications tonight, and I'm not sure why I received them and, whether others have received them. I wonder whether they are related to some of the changes made related to Gina's issue today on the CAC. Original emails attached here


Related issues

Related to CUNY Academic Commons - Bug #8225: replies to a blog post activity itemResolved2017-06-05

Related to CUNY Academic Commons - Bug #10800: Duplicate email notifications on blog commentsResolved2018-12-07

History

#1 Updated by Boone Gorges over 2 years ago

  • Subject changed from Spam email notifications to Email notifications of spammed comment on groupblog
  • Assignee changed from Boone Gorges to Raymond Hoh

"BLOCKED BY STBV" comes from a plugin Simple Trackback Validation that is network-activated on the Commons.

Obviously, spammed comments should not be generating email notifications. It could be that there's a connection between this and recent spam-related issues, but this appears to be a different kind of problem - instead of double-triggering of activity notifications, it's the generation of activity for spammed comments.

Ray, can you please have a look, as the logic is probably adjacent to #11160, and maybe #11164?

#2 Updated by Raymond Hoh over 2 years ago

  • Related to Bug #8225: replies to a blog post activity item added

#3 Updated by Raymond Hoh over 2 years ago

  • Related to Bug #10800: Duplicate email notifications on blog comments added

#4 Updated by Raymond Hoh over 2 years ago

  • Status changed from Assigned to In Progress
  • Target version set to 1.14.8

I have a feeling we need to patch up the BP Include Non Member Comments plugin to only allow regular comments to be recorded into the activity stream.

I've done so here: https://github.com/cuny-academic-commons/cac/commit/8368f72771b272a2f5eba0308937e18ce9947340

I'm deploying this as a hotfix to production, but I'm unsure if this will 100% address the issue. This is theoretical at the moment as I haven't had time to generate trackbacks on a groupblog for testing.

Let's keep an eye on this for the next few days.

Ray, can you please have a look, as the logic is probably adjacent to #11160, and maybe #11164?

These issues have popped up due to the introduction to reply to groupblog comments via email (#8225), which in turn required changes to BP Groupblog and unbeknownst to me at the time, affected the BP Include Non Member Comments plugin (#10800) and how it interacts with the group activity stack and group email notifications.

#5 Updated by Matt Gold over 2 years ago

Thank you, Ray

#6 Updated by Boone Gorges over 2 years ago

Thanks, Ray. This change to BP Include Non Member Comments seems like a good one to me.

#7 Updated by Raymond Hoh over 2 years ago

  • Status changed from In Progress to Resolved

No follow-up reports equals progress!

Going to mark this one as resolved for now.

Also available in: Atom PDF