Project

General

Profile

Bug #11243

Audit bp-custom.php

Added by Raymond Hoh 5 months ago. Updated 4 months ago.

Status:
New
Priority name:
Normal
Assignee:
Category name:
BuddyPress (misc)
Target version:
Start date:
2019-03-19
Due date:
% Done:

0%

Estimated time:

Description

Over the years, we've added a lot of code to our BuddyPress custom code file - bp-custom.php.

Some of that code is no longer applicable to the Commons today. It's time to trim the fat for 1.15!

BP_Error.PNG (4.72 KB) BP_Error.PNG Michael Shields, 2019-04-23 08:47 PM

History

#1 Updated by Raymond Hoh 5 months ago

I've done the following so far:

bbPress v1 is no longer in use on the Commons and both oohEmbed and ForaTV's websites no longer exist.

I'll do one more sweep of the bp-custom.php file in the next week or so.

#2 Updated by Matt Gold 5 months ago

I love this kind of housekeeping. Thank you for doing it!

#3 Updated by Boone Gorges 4 months ago

  • Target version changed from 1.15 to 1.16

Let's do another concerted sweep for 1.16.

#4 Updated by Michael Shields 4 months ago

Hi guys,

I'm not sure if this bug is related to this thread but when I went to edit https://oirap.commons.gc.cuny.edu/applications-admissions/cas-freshman-application-data/, I saw the attached error message. When I clicked on the link, I received a "Sorry, you are not allowed to access this page." error message. Note that we do not use email functionality on that (or any) page on that site.

BTW, in the nearly 11 months since rolling out the OIRA Wiki to the larger CUNY community, everyone LOVES it! Thank you so much for all of your support last spring and summer as I worked to get things up and running. I couldn't have done it without this fantastic team!

#5 Updated by Matt Gold 4 months ago

That's so fantastic to hear, Michael -- thank you for letting us know!!!

#6 Updated by Boone Gorges 4 months ago

Thanks for reporting this, Michael. The issue you've noted is unrelated to the bp-custom.php changes in this ticket, but instead comes from some unrelated plugin updates in yesterday's maintenance release. I've made the necessary changes to ensure that you'll no longer see this notice. (See also https://github.com/boonebgorges/buddypress-group-email-subscription/issues/174 for the distribution plugin.)

#7 Updated by Michael Shields 4 months ago

Thank you, Boone. I confirm that I'm no longer seeing that message.

Also available in: Atom PDF