Project

General

Profile

Actions
Copy link

Bug #11243

open

Audit bp-custom.php

Added by Raymond Hoh over 5 years ago. Updated 3 months ago.

Status:
New
Priority name:
Normal
Assignee:
Raymond Hoh
Category name:
BuddyPress (misc)
Target version:
Future release
Start date:
2019-03-19
Due date:
% Done:

0%

Estimated time:
Deployment actions:

Description

Over the years, we've added a lot of code to our BuddyPress custom code file - bp-custom.php.

Some of that code is no longer applicable to the Commons today. It's time to trim the fat for 1.15!

Files

BP_Error.PNG (4.72 KB) BP_Error.PNG Michael Shields, 2019-04-23 08:47 PM
Actions
Copy link
 #1

Updated by Raymond Hoh over 5 years ago

I've done the following so far:

bbPress v1 is no longer in use on the Commons and both oohEmbed and ForaTV's websites no longer exist.

I'll do one more sweep of the bp-custom.php file in the next week or so.

Actions
Copy link
 #2

Updated by Matt Gold over 5 years ago

I love this kind of housekeeping. Thank you for doing it!

Actions
Copy link
 #3

Updated by Boone Gorges over 5 years ago

  • Target version changed from 1.15 to 1.16

Let's do another concerted sweep for 1.16.

Actions
Copy link
 #4

Updated by Michael Shields over 5 years ago

Hi guys,

I'm not sure if this bug is related to this thread but when I went to edit https://oirap.commons.gc.cuny.edu/applications-admissions/cas-freshman-application-data/, I saw the attached error message. When I clicked on the link, I received a "Sorry, you are not allowed to access this page." error message. Note that we do not use email functionality on that (or any) page on that site.

BTW, in the nearly 11 months since rolling out the OIRA Wiki to the larger CUNY community, everyone LOVES it! Thank you so much for all of your support last spring and summer as I worked to get things up and running. I couldn't have done it without this fantastic team!

Actions
Copy link
 #5

Updated by Matt Gold over 5 years ago

That's so fantastic to hear, Michael -- thank you for letting us know!!!

Actions
Copy link
 #6

Updated by Boone Gorges over 5 years ago

Thanks for reporting this, Michael. The issue you've noted is unrelated to the bp-custom.php changes in this ticket, but instead comes from some unrelated plugin updates in yesterday's maintenance release. I've made the necessary changes to ensure that you'll no longer see this notice. (See also https://github.com/boonebgorges/buddypress-group-email-subscription/issues/174 for the distribution plugin.)

Actions
Copy link
 #7

Updated by Michael Shields over 5 years ago

Thank you, Boone. I confirm that I'm no longer seeing that message.

Actions
Copy link
 #8

Updated by Boone Gorges about 5 years ago

  • Target version changed from 1.16 to 1.17.0

This is an ongoing task.

Actions
Copy link
 #9

Updated by Boone Gorges over 4 years ago

  • Target version changed from 1.17.0 to 1.18.0
Actions
Copy link
 #10

Updated by Boone Gorges about 4 years ago

  • Target version changed from 1.18.0 to 1.19.0
Actions
Copy link
 #11

Updated by Boone Gorges about 3 years ago

  • Target version changed from 1.19.0 to 2.0.0
Actions
Copy link
 #12

Updated by Boone Gorges over 2 years ago

  • Target version changed from 2.0.0 to Future release
Actions
Copy link
 #13

Updated by Raymond Hoh 3 months ago

I've done another round of auditing bp-custom.php:

- Remove BuddyPress Docs header. No longer necessary due to the Group Library feature - https://github.com/cuny-academic-commons/cac/commit/90ba5bbc3f622bbd839fcf385a25856e7040fb35
- Remove BuddyPress Docs TinyMCE buttons mod - https://github.com/cuny-academic-commons/cac/commit/5143bb1ec6c11ae39baf36afe4b7600ea8ee20f4
- Remove Viper's Video Tags deactivation script - https://github.com/cuny-academic-commons/cac/commit/e0b86ec6f0c0ee495a1235930b48c89f3b4e7942
- Remove arras-theme fix - https://github.com/cuny-academic-commons/cac/commit/b504e59c27be1c951188c8da441f03e5fd85bbb0

There probably are some other things we can remove, but these were the easy wins.

Actions
Copy link

Also available in: Atom PDF