Project

General

Profile

Bug #11610

Homepage thumbnails not loading

Added by Matt Gold over 2 years ago. Updated about 2 years ago.

Status:
Resolved
Priority name:
Normal
Assignee:
Category name:
-
Target version:
Start date:
2019-06-28
Due date:
% Done:

0%

Estimated time:

Description

I'm seeing the same issue that Lihua noted via email on Thursday -- thumbnail avatar images on the homepage are not loading. Screenshot attached


Related issues

Copied to CUNY Academic Commons - Bug #11619: Homepage thumbnails not loadingRejected2019-06-28

History

#1 Updated by Boone Gorges over 2 years ago

I've deleted the .htaccess file.

Ray, I just broadened the debug tool. See the wp_mail calls in wp-content/mu-plugins/cac-file-protection.php. We'll both be getting emails anytime .htaccess files are generated, which will be annoying for a while, but I can't think of another way to figure out what's going on. Let's watch for a few days and see what happens. (I'm adding you in case this doesn't get sorted by the time I'm on vacation.)

#2 Updated by Boone Gorges over 2 years ago

I just had an idea what may be causing this: It used to be that update_blog_public only fired on site dashboards, so that the $site_id passed to the hook matched the output of get_current_blog_id(). After recent changes to the site creation process, this may no longer be happening - specifically, in the case of groupblog creation. So it could be that $site_id is the correct (new) site, but wp_upload_dir() (in get_htaccess_path()) is returning the upload dir for site 1. There's no straightforward way to generate the upload dir based on $site_id, so we'll need to do some string manipulation. I don't have the time to test and debug this right now, but I'm writing it down here so that it can be addressed in the next few days, when Ray or I get to it.

#3 Updated by Boone Gorges over 2 years ago

  • Status changed from Assigned to Resolved
  • Target version set to 1.15.5

I tested my hypothesis this morning, and it was correct. It's been fixed in https://github.com/cuny-academic-commons/cac/commit/bea25cd8ac039b9dbf3ed2748e2542e716b96d74 and deployed to the production site.

#4 Updated by Matt Gold over 2 years ago

Thanks so much for your quick work on this, Boone

#5 Updated by Raymond Hoh about 2 years ago

Great catch, Boone. Enjoy your time off!

#6 Updated by Matt Gold about 2 years ago

  • Copied to Bug #11619: Homepage thumbnails not loading added

Also available in: Atom PDF