Bug #11649: CC license displayed on every page - CUNY Academic Commons - CUNY Graduate Center - Project Tracking System

Actions

Copy link

#1

Updated by Boone Gorges over 5 years ago

Assignee set to Raymond Hoh
Target version set to 1.15.6

Ray, could you please have a look?

Actions

Copy link

#2

Updated by Raymond Hoh over 5 years ago

Category name set to WordPress Plugins
Status changed from New to In Progress

Thanks for the report, Gina.

The license that appears at the end of posts or pages is meant to be shown if it differs from the site license displayed in the widget.

From what I've seen on the CELTS site, some pages use a different license, so that's why the license is shown at the end of the page or post. Currently, the site license for the CETLS site is BY-NC, but some pages and posts use BY-NC-SA.

What I'm guessing happened is the site license was BY-NC-SA before and some posts created during this time inherited that license. Sometime afterwards, the site license was changed to BY-NC, but this did not change the existing licenses for previous posts and pages.

At the moment, it isn't possible to bulk-change the licenses from the main Posts or Pages admin dashboard, but I'll add this functionality so site admins can make bulk-license changes to posts based on this use-case. I'll probably also add a blurb to the "Settings > Writing" admin page to explain what happens when changing the site license.

Actions

Copy link

#3

Updated by Raymond Hoh over 5 years ago

While trying to duplicate the differing license issue, I discovered a bug.

The problem is we had some custom code to save the site license that was only meant to run on the frontend's "Group + Site" creation page. However, it ended up that this code was always running in the admin area, which caused the wrong license to be saved for the site license whenever a post is saved -- the site license would inherit whatever the last, saved post license was.

To fix this, I've removed this code:
https://github.com/cuny-academic-commons/cac/commit/14d954ee8c424d75ec083734cf0995ba48ccbcef

And added this functionality directly into our cac-creative-commons plugin:
https://github.com/cuny-academic-commons/cac-creative-commons/commit/6c9df34e6db132954ba49485c01d6848c1d589d0

(Boone, I've updated the ACTION_REQUIRED list because the cac-creative-commons plugin will need an update for the next maintenance release.)

For 1.15.6, I wanted to get the bulk management license feature working on the admin post management screen, but I ran out of time. I'll work on this for the next maintenance release.

Actions

Copy link

#4

Updated by Boone Gorges over 5 years ago

Target version changed from 1.15.6 to 1.15.7

Actions

Copy link

#5

Updated by Boone Gorges over 5 years ago

Thanks, Ray!

Actions

Copy link

#6

Updated by Gina Cherry over 5 years ago

Update to this issue. I think the original problem that I reported was also related to whether or not the CC license widget is displayed on the site. When I first noticed the issue, I was not displaying the CC license widget and as a result, the license appeared at the bottom of the main area of every page. When I added the widget in the footer, the CC license still appeared on the main area of pages that used a different license from the site, but appeared only in the footer on other pages.

I just saw this replicated on a site created by a faculty member in our open pedagogy seminar. The CC license was appearing in the main area of every page in her site. When I added the CC widget to the footer, we no longer saw the CC license in the main area of each page, but instead saw it in the footer on each page, which was preferable.

This may be more of a user issue than a bug. When you create a new site, you're prompted to choose a CC license, but it's not clear that there is a CC widget that should be included. I discovered the widget somewhat by accident. Perhaps there could be more explicit instruction for users.

(Sorry if this is not clear - I'm writing with very loud construction noise in the background and it's hard to think straight!)

Actions

Copy link

#7

Updated by Raymond Hoh over 5 years ago

File license-bulk-edit.png license-bulk-edit.png added

This may be more of a user issue than a bug. When you create a new site, you're prompted to choose a CC license, but it's not clear that there is a CC widget that should be included. I discovered the widget somewhat by accident. Perhaps there could be more explicit instruction for users.

Yes, I think we can do a better job with documentation here, especially with regards to using the CC widget to display the site license and what effect the CC widget plays in displaying the post license.

I'll work on this, and might rope in Scott for help.

For 1.15.6, I wanted to get the bulk management license feature working on the admin post management screen, but I ran out of time. I'll work on this for the next maintenance release.

The bulk management license feature is added for 1.15.7 to account for what I mentioned in comment 2. I've attached a screenshot of how it works.

Code reference: https://github.com/cuny-academic-commons/cac/commit/cf80e116c7e029cb8fcfab81c94a824c03266a39

Boone, this requires a git submodule update during the maintenance release.

Actions

Copy link

#8