Project

General

Profile

Actions
Copy link

Bug #12551

closed

Preparing for PHP 7.4

Added by Raymond Hoh about 4 years ago. Updated almost 4 years ago.

Status:
Resolved
Priority name:
Normal
Assignee:
-
Category name:
WordPress (misc)
Target version:
1.17.0
Start date:
2020-03-16
Due date:
% Done:

0%

Estimated time:
Deployment actions:

Description

Previously: #10564 for PHP 7.2.

This is a master ticket to gather fixes related to PHP 7.4, which will be applied to the production server in a few months from now.

Related issues

Related to CUNY Academic Commons - Bug #12753: PHP 7.4 compatDuplicate2020-05-05

Actions
Related to CUNY Academic Commons - Bug #9068: PHP 7.2 compatibilityResolvedBoone Gorges2018-01-09

Actions
Related to CUNY Academic Commons - Bug #10564: PHP 7.2 Incompatibility ProblemsResolvedRaymond Hoh2018-10-19

Actions
Actions
Copy link
 #1

Updated by Raymond Hoh about 4 years ago

Came across a deprecated array notice for Event Organiser. Fixed here:
https://github.com/cuny-academic-commons/cac/commit/e2dd5434172bac0a3c2cf952f778538d3f92623f

I've also sent a PR to the plugin author.

Actions
Copy link
 #2

Updated by Boone Gorges almost 4 years ago

Actions
Copy link
 #3

Updated by Boone Gorges almost 4 years ago

From #12753:

In https://github.com/cuny-academic-commons/cac/commit/4100d60877da7f50b6479673b32dd6da27438aba I bumped the PHPCompatibility sniffs to 7.4 (and fixed a bug that made it impossible to test the entire codebase properly).

In https://github.com/cuny-academic-commons/cac/commit/3c06e2593a2cd037c4740868ee2fd013d596139e I made a change so that CircleCI runs PHP 7.4, ensuring that the php -l lint tool will work properly.

Actions
Copy link
 #4

Updated by Boone Gorges almost 4 years ago

  • Related to Bug #9068: PHP 7.2 compatibility added
Actions
Copy link
 #5

Updated by Boone Gorges almost 4 years ago

  • Related to Bug #10564: PHP 7.2 Incompatibility Problems added
Actions
Copy link
 #7

Updated by Boone Gorges almost 4 years ago

  • Target version changed from Not tracked to 1.17.0

I've completed a sweep through the notices.

wp-ui https://github.com/cuny-academic-commons/cac/commit/f3a72b6da344b97dc60c40ccdf9cb9ff73c27ff0
twitter-mentions-as-comments https://github.com/cuny-academic-commons/cac/commit/c254c696949894ad4552996748b47b4fdfec7113
js_composer https://github.com/cuny-academic-commons/cac/commit/e0944c4f874479c768a750a9179cff8867e89d4c
video-playlist-and-gallery-plugin https://github.com/cuny-academic-commons/cac/commit/9f564770cb96f19d822b71c5b39b67161a9ebd14
bloom https://github.com/cuny-academic-commons/cac/commit/fe82a21970de1cbf06df0e300acbc81cc42425ee
bbpress https://github.com/cuny-academic-commons/cac/commit/a0dbd96a55c29b8dfdd107fb862ce487daa1fbc7
sign-up-sheets https://github.com/cuny-academic-commons/cac/commit/3a6022425fd13fe691293e796ffc39b0b965b085
email-users https://github.com/cuny-academic-commons/cac/commit/b7088a3530e5945b5fc18657ea91614fc97533e7
xili-language https://github.com/cuny-academic-commons/cac/commit/35b6380aefd1886ac9c58a8d1b325796a7999797
amazon-link https://github.com/cuny-academic-commons/cac/commit/e8453731b2983ec790e59780a3322c6995131252
wysija-newsletters https://github.com/cuny-academic-commons/cac/commit/e3f9a7409b74d6cd35be13adaaf3863330cf7ebf
cac-group-library https://github.com/cuny-academic-commons/cac/commit/b49cdb569f98c810d00ee2df3d8dcbb8d3361b14
blog-as-pdf https://github.com/cuny-academic-commons/cac/commit/b414f2e187951fb5fd84eede398440716a03b7d8

I think this work is mostly done, but I'm going to leave the ticket open in case there's a bit more cleanup. I'm also moving to a milestone so that we have a way to track changes to the codebase against a release.

Actions
Copy link
 #9

Updated by Boone Gorges almost 4 years ago

More fixes:

LayerSlider https://github.com/cuny-academic-commons/cac/commit/4b9e1cf8f28c7d110236b87437a33dda547e2ed2, https://github.com/cuny-academic-commons/cac/commit/60ea9b44f3d1ef53eccea6175afb359f724302aa
the-events-calendar https://github.com/cuny-academic-commons/cac/commit/37c57502baa9735f395da54ba5adc08e4b3359a5
monarch https://github.com/cuny-academic-commons/cac/commit/111ecb2cc7b3b820f0576ea798c1a217ed0fb43e
leaflet-maps-maker https://github.com/cuny-academic-commons/cac/commit/040ed1b2dd4d4e0c1be63de88a5a91bc64e116f4
event-tickets https://github.com/cuny-academic-commons/cac/commit/29ab148b815e5ae492c9d01806dd6bc9f6f097a3
newsletters-lite https://github.com/cuny-academic-commons/cac/commit/6ecb640cb43e3ac610029ee9406f8c674b80c8db
ninja-forms https://github.com/cuny-academic-commons/cac/commit/0697e93317928902dd49180de999bbc54608ef7b
revslider https://github.com/cuny-academic-commons/cac/commit/500eb4a5fe74975451e1b83c3697933954ae425e
onetone https://github.com/cuny-academic-commons/cac/commit/6c5d91b167d2ae35ec692a86843ee60f3b38dc7c
13Floor https://github.com/cuny-academic-commons/cac/commit/a28416162b2d6937903e739dff2c0eaf562e735b
pressforward https://github.com/cuny-academic-commons/cac/commit/ea8a5c99351e4f7dc31bd5466f4e828e6586066e (passed upstream)
Lucid https://github.com/cuny-academic-commons/cac/commit/ef9864ef41724faf95cc429a819e3271f4ed3577
Cion https://github.com/cuny-academic-commons/cac/commit/13cc2af673620206530625d6ec874562514faaa4
Basic https://github.com/cuny-academic-commons/cac/commit/5b290a49241911b0e70dcd112a19d5d7aff14c9a
make https://github.com/cuny-academic-commons/cac/commit/ebc36bc6efeb62f9488d857d88263a3582c3ad6c
DailyNotes https://github.com/cuny-academic-commons/cac/commit/bb166b45bf1841c4560be0dc965f18b833e4a154
AskIt, etc https://github.com/cuny-academic-commons/cac/commit/14c12cf46c956e187aff690dc8aacf96e5bea41f

Actions
Copy link
 #11

Updated by Boone Gorges almost 4 years ago

I'm running a final scan, but in my local tests it looks like we are fully passing the PHPCS compatibility scan.

Actions
Copy link
 #12

Updated by Boone Gorges almost 4 years ago

Just to get a clean run of the linter, I added some hotfixes for PHP syntax notices - mostly related to the use of continue inside switch blocks.

cforms https://github.com/cuny-academic-commons/cac/commit/6f2c6867691f254974a10d99e68f958088c0a68c
custom-user-css https://github.com/cuny-academic-commons/cac/commit/85a4ffcc38e1f9d262c8e826925dfe9806539bb0
easy-visualization-tools https://github.com/cuny-academic-commons/cac/commit/39bae9ff907806fa4ca4578cc7f86636fa7ac1ab
leaflet-maps-marker https://github.com/cuny-academic-commons/cac/commit/5382a63e5771d86853ef89d37ec015306d720ee8
widget-entries https://github.com/cuny-academic-commons/cac/commit/f152d38f3cfca09b6fb57f3575ef6ae4d324754f
anthologize https://github.com/cuny-academic-commons/cac/commit/328bd149d254ae4d51874edf8814e46b4fa266c1
business-directory-plugin https://github.com/cuny-academic-commons/cac/commit/5702401d0a5a305cf1b70a766f614771cae1b7d4
wp-markdown https://github.com/cuny-academic-commons/cac/commit/c67a0b1c2f195d8aecbef83ac8f8f5f87a8cb261
wp-post-to-pdf https://github.com/cuny-academic-commons/cac/commit/09117f026b647b1374dfa840c29dd88ec204be23
wysija-newsletters https://github.com/cuny-academic-commons/cac/commit/832f5c57baf38df2e9dc07375bb9f2236084d629
newsletters-lite https://github.com/cuny-academic-commons/cac/commit/0706f872285c2d03e4491edbc1defc6df798e7c7
pressforward https://github.com/cuny-academic-commons/cac/commit/caa5e18d2ab6e8f587d385f6a0a2ee0d1c1ec496, https://github.com/cuny-academic-commons/cac/commit/76803e50d6ede4e898121610b3893534ef64ca75

Actions
Copy link
 #13

Updated by Boone Gorges almost 4 years ago

  • Status changed from New to Resolved

Our linting routines are passing, so I think this work is pretty much done.

Actions
Copy link

Also available in: Atom PDF