Bug #12594
closedRemove Backtype Connect plugin
0%
Description
I'm just going through the error logs to see what we can do about the server problem and I noticed an error for the backtype-connect plugin.
Just did some research and Backtype was acquired by Twitter and their site/API is no longer available, so we can remove this plugin from the Commons.
I've slated the removal this for 1.17, but we can remove for a 1.16.x maintenance release as well if we wanted to.
Updated by Boone Gorges over 4 years ago
Sounds like a good idea to me, Ray. Can you think of any potential breakage from simply removing the plugin? Presumably we wouldn't be removing functionality on any existing sites, since it's broken?
Updated by Raymond Hoh over 4 years ago
I took a closer look at the plugin and besides trying to connect to Backtype when a comment is posted, it does modify the comment avatar and reply link. I just checked wp.org and the plugin is no longer available for download so I would just recommend removing it outright.
If we want to be conservative, we can just unhook their comment ping routine.
Boone, I wanted to determine how many sites were running the plugin with the wp-cli package - https://github.com/iandunn/wp-cli-plugin-active-on-sites/, but it hung on me after awhile.
Are you using another wp-cli package? If so, which one?
Updated by Raymond Hoh over 4 years ago
I was able to run wp plugin active-on-sites on the dev server and it returned six sites:
+---------+-----------------------------------------+ | blog_id | url | +---------+-----------------------------------------+ | 15 | https://news.commons.gc.cuny.edu/ | | 34 | https://dev.commons.gc.cuny.edu/ | | 393 | https://cunydhi.commons.gc.cuny.edu/ | | 457 | https://rowenali.commons.gc.cuny.edu/ | | 1506 | https://eshtestcac.commons.gc.cuny.edu/ | | 1671 | https://abcdefg.commons.gc.cuny.edu/ | +---------+-----------------------------------------+
I've deactivated backtype-connect from all six sites on production.
I believe that should cover most of the sites, but I'll run the wp-cli command again on production later tonight when the server load should be lighter.
Then we can remove the plugin outright.
Updated by Raymond Hoh over 4 years ago
- Target version changed from 1.17.0 to 1.16.9
Just ran wp plugin active-on-sites backtype-connect on the production server and came up with two additional sites running the plugin:
+---------+------------------------------------------+ | blog_id | url | +---------+------------------------------------------+ | 4730 | https://quincyworks.commons.gc.cuny.edu/ | | 6697 | https://leec.commons.gc.cuny.edu/ | +---------+------------------------------------------+
Took almost four times as long to run on the production server though (close to twenty minutes compared to five on the dev server).
I've just disabled backtype-connect for those two sites. Boone, I plan to remove backtype-connect from the codebase in 1.16.9 as well unless you want to do this in 1.17 instead.
One other thing is when I ran the wp-cli command, wp-cli threw some errors about two sites that do not have any wp_options tables.
The two sites do exist in the wp_blogs table though:
+---------+---------+---------------------------------+------+---------------------+---------------------+--------+----------+--------+------+---------+---------+ | blog_id | site_id | domain | path | registered | last_updated | public | archived | mature | spam | deleted | lang_id | +---------+---------+---------------------------------+------+---------------------+---------------------+--------+----------+--------+------+---------+---------+ | 7851 | 1 | chrisdookie.commons.gc.cuny.edu | / | 2019-05-13 03:14:58 | 0000-00-00 00:00:00 | 1 | 0 | 0 | 0 | 0 | 0 | | 7852 | 1 | chrisdookie.commons.gc.cuny.edu | / | 2019-05-13 03:15:29 | 0000-00-00 00:00:00 | 1 | 0 | 0 | 0 | 0 | 0 | +---------+---------+---------------------------------+------+---------------------+---------------------+--------+----------+--------+------+---------+---------+
I think it should be safe to delete those sites with wp_delete_site().
Let me know what you think, Boone.
Updated by Boone Gorges over 4 years ago
Removing backtype-connect seems fine to me. Let's do it at the next release.
Sounds fine to me to delete the broken sites. I'll leave it to you, Ray :)
Updated by Raymond Hoh over 4 years ago
- Status changed from New to Staged for Production Release
I've removed backtype-connect here - https://github.com/cuny-academic-commons/cac/commit/8b8cff75cd2ca1207f4c56efbf379000d1f2cd46
And I've just removed the two sites mentioned above.
Updated by Boone Gorges over 4 years ago
- Status changed from Staged for Production Release to Resolved