Project

General

Profile

Actions

Bug #13296

closed

Enqueue jquery-migrate

Added by Boone Gorges over 2 years ago. Updated over 2 years ago.

Status:
Resolved
Priority name:
Normal
Assignee:
Category name:
-
Target version:
Start date:
2020-09-07
Due date:
% Done:

0%

Estimated time:
Deployment actions:

Description

As part of the WP 5.5 upgrade that we'll be performing later in the month, jquery-migrate is no longer enqueued by default when jquery is enqueued. We need to ensure compatibility for bp-nelo, which we can either do by remediating the errors or by enqueuing jquery-migrate (the latter is obviously much easier). But we also might want to consider globally enqueuing jquery-migrate for the time being, because it's likely that other plugins/themes using jQuery on our many sites will break without jquery-migrate. We will need a plan of attack for addressing this problem in the longer term, but for now it might be wise to use the global band-aid. Ray, I'm CCing you in case you have opinions about this.


Related issues

Related to CUNY Academic Commons - Bug #13352: jQuery update for bp-neloResolvedBoone Gorges2020-09-21

Actions
Related to CUNY Academic Commons - Bug #13378: problem on one of my sitesResolved2020-09-24

Actions
Actions #1

Updated by Boone Gorges over 2 years ago

  • Status changed from New to Staged for Production Release

Here's what I'm going to do for 1.17.4 and the WP 5.5.x update: https://github.com/cuny-academic-commons/cac/commit/0a61df965c67fed4e3b6ffad5839310eef074cb7

This does two things:

1. Enqueues jquery-migrate on the root site, via bp-nelo
2. Enqueues jquery-migrate on all secondary sites where jquery is also enqueued

Doing it separately means that we can roll these changes back separately, as needed.

I'll open separate tickets for the removal of jquery-migrate.

Actions #2

Updated by Boone Gorges over 2 years ago

  • Related to Bug #13352: jQuery update for bp-nelo added
Actions #3

Updated by Boone Gorges over 2 years ago

  • Status changed from Staged for Production Release to Resolved
Actions #4

Updated by Boone Gorges over 2 years ago

  • Related to Bug #13378: problem on one of my sites added
Actions

Also available in: Atom PDF