Project

General

Profile

Bug #13352

jQuery update for bp-nelo

Added by Boone Gorges 12 months ago. Updated 5 months ago.

Status:
Resolved
Priority name:
Normal
Assignee:
Category name:
-
Target version:
Start date:
2020-09-21
Due date:
% Done:

0%

Estimated time:

Description

In #13296 I enqueued jquery-migrate on bp-nelo, so that we didn't experience unexpected breakage after the WP 5.5 upgrade.

In advance of WP 5.6, where the default jQuery will be updated to the latest version, we should preemptively update bp-nelo's jQuery to the latest. Let's use this ticket to track the necessary changes.


Related issues

Related to CUNY Academic Commons - Bug #13296: Enqueue jquery-migrateResolved2020-09-07

Related to CUNY Academic Commons - Bug #13494: Brief Descriptor and About You Profile Fields do not display on mobile devicesResolved2020-10-23

Related to CUNY Academic Commons - Feature #13789: Update WordPress to 5.6.xResolved2021-01-07

Related to CUNY Academic Commons - Support #14129: can only see some invites sentResolved2021-03-06

Related to CUNY Academic Commons - Bug #14716: My Commons activity blankResolved2021-08-17

History

#1 Updated by Boone Gorges 12 months ago

  • Related to Bug #13296: Enqueue jquery-migrate added

#2 Updated by Boone Gorges 11 months ago

  • Related to Bug #13494: Brief Descriptor and About You Profile Fields do not display on mobile devices added

#3 Updated by Boone Gorges 10 months ago

  • Target version changed from 1.18.0 to 1.19.0

I spent a good deal of time trying to sort out bp-nelo and the plugins that we run on the main site. The rabbit hole is deep here: cac-advanced-profiles, for example, uses a library (jquery-waypoints) that has since been updated for the latest jQuery, but this update included major changes to the API. There are other cases like this. I'm going to keep working on it during the 1.19 cycle. In the meantime, if we see a WP update that changes the default version of jQuery, we'll ensure that the migrate tools are available.

#4 Updated by Boone Gorges 8 months ago

#5 Updated by Boone Gorges 8 months ago

  • Target version changed from 1.19.0 to 1.18.5

Let's get to a workable solution for the WP 5.6 upgrade, scheduled for late February.

#6 Updated by Boone Gorges 7 months ago

  • Target version changed from 1.18.5 to 1.18.7

Bumping this to March for further consideration.

I've finished much of the necessary work on this (see https://github.com/cuny-academic-commons/cac/commits/wp56) but I need to push this out at the same time as the broader #13343.

#7 Updated by Boone Gorges 6 months ago

  • Status changed from New to Staged for Production Release

#8 Updated by Boone Gorges 6 months ago

  • Status changed from Staged for Production Release to Resolved

#9 Updated by Raymond Hoh 5 months ago

In the following commit, we switched from the jQuery Cookie plugin to js-cookie. This broke the bp_get_cookies() function call used in bp-nelo. See #14129.

I've just updated the bp_get_cookies() function so it uses the js-cookie logic and applied the fix to production: https://github.com/cuny-academic-commons/cac/commit/07eabf86ece2dc996038a57e2fd2641b5305df83

#10 Updated by Raymond Hoh 5 months ago

#11 Updated by Raymond Hoh 5 months ago

Added a couple of other jQuery deprecated fixes for bp-nelo: https://github.com/cuny-academic-commons/cac/compare/07eabf8...df9d9f2

#12 Updated by Boone Gorges 5 months ago

Thanks, Ray, and sorry for botching that part of the migration :-/

#13 Updated by Raymond Hoh about 1 month ago

  • Related to Bug #14716: My Commons activity blank added

Also available in: Atom PDF