jQuery update for bp-nelo
In #13296 I enqueued jquery-migrate on bp-nelo, so that we didn't experience unexpected breakage after the WP 5.5 upgrade.
In advance of WP 5.6, where the default jQuery will be updated to the latest version, we should preemptively update bp-nelo's jQuery to the latest. Let's use this ticket to track the necessary changes.
#3 Updated by Boone Gorges 10 months ago
- Target version changed from 1.18.0 to 1.19.0
I spent a good deal of time trying to sort out bp-nelo and the plugins that we run on the main site. The rabbit hole is deep here: cac-advanced-profiles, for example, uses a library (jquery-waypoints) that has since been updated for the latest jQuery, but this update included major changes to the API. There are other cases like this. I'm going to keep working on it during the 1.19 cycle. In the meantime, if we see a WP update that changes the default version of jQuery, we'll ensure that the migrate tools are available.
#6 Updated by Boone Gorges 7 months ago
- Target version changed from 1.18.5 to 1.18.7
Bumping this to March for further consideration.
I've finished much of the necessary work on this (see https://github.com/cuny-academic-commons/cac/commits/wp56) but I need to push this out at the same time as the broader #13343.
#9 Updated by Raymond Hoh 5 months ago
I've just updated the
bp_get_cookies() function so it uses the
js-cookie logic and applied the fix to production: https://github.com/cuny-academic-commons/cac/commit/07eabf86ece2dc996038a57e2fd2641b5305df83
#11 Updated by Raymond Hoh 5 months ago
Added a couple of other jQuery deprecated fixes for bp-nelo: https://github.com/cuny-academic-commons/cac/compare/07eabf8...df9d9f2