Project

General

Profile

Bug #13473

Some categories in the customize panel are still missing on the PressForward theme

Added by Sage Yim 12 months ago. Updated 10 months ago.

Status:
Resolved
Priority name:
Normal
Assignee:
-
Category name:
WordPress Themes
Target version:
Start date:
2020-10-15
Due date:
% Done:

0%

Estimated time:

Description

  • This is a follow up re: Bug #13418 (customize panel not showing on the PressForward theme).

Thank you for looking into the issue. The customize panel is now showing on the theme. However, there still seems to be an issue with it.
Under the "Home Page Layout" panel, I only see two categories (slider options and footer) even though there need to be four additional categories (blocks #2 to #5). This "Home Page Layout" panel is one of the important panels that shows a lot of crucial information in my static home page. So I need to be able to change the content frequently.

Could you please check this issue? Thank you very much.

[[https://github.com/PressForward/pressforward-turnkey-theme/wiki/PressForward-Theme-Options]]

Best,
Sage

pressforward issue 01.JPG (167 KB) pressforward issue 01.JPG list of other categories that need to be in the panel Sage Yim, 2020-10-15 12:44 PM
pressforward issue 02.JPG (126 KB) pressforward issue 02.JPG the categories I currently see (only two) Sage Yim, 2020-10-15 12:45 PM

History

#1 Updated by Boone Gorges 12 months ago

  • Status changed from New to Reporter Feedback
  • Target version set to 1.17.6

I poked around for a bit and noticed that pressforward-turnkey-theme registered its Customizer sections with capital letters ("Block2") but later referenced them with lowercase ("block2"). There must've been a change in the Kirki library such that these strings used to be case-insensitive but now are case-sensitive. As such, the Customizer sections were empty (no associated fields) and so weren't rendered. I standardized on lowercase and it now appears to be working. This change is live on the production site.

For broader context, it looks like the pressforward-turnkey-theme is no longer actively maintained by the PF team. I have pushed up a branch that contains my fixes, and once we're satisfied that they're working reasonably well I can send a pull request to the repo. See https://github.com/PressForward/pressforward-turnkey-theme/tree/kirki-upgrade But I'm not sure whether anyone will be there to receive the PR.

#2 Updated by Boone Gorges 11 months ago

  • Target version changed from 1.17.6 to 1.17.7

Punting this one more version in case there's more user feedback. In a week or two I'll process a PR for the GitHub repo.

#3 Updated by Boone Gorges 11 months ago

  • Target version changed from 1.17.7 to 1.17.8

#4 Updated by Lisa Rhody 11 months ago

Hi Boone... If you issue that pull request, I'll be sure to follow up with Mandy and Sean. The theme is a separate repository from the plugin. Once the PR is initiated, I can also ask them about future plans. As you know, future active development is contingent on a pending funding request, but there are no outstanding PRs on the repository that I can see.

Thanks for your help!

#5 Updated by Boone Gorges 11 months ago

Thanks, Lisa. I've opened the PR at https://github.com/PressForward/pressforward-turnkey-theme/pull/89 and added you as a reviewer.

#6 Updated by Boone Gorges 10 months ago

  • Status changed from Reporter Feedback to Resolved

Looks like the PR has been merged upstream, so I think we can mark this one resolved.

Also available in: Atom PDF