Project

General

Profile

Bug #13934

Error message on group settings change

Added by Matt Gold 9 months ago. Updated 9 months ago.

Status:
Resolved
Priority name:
Low
Assignee:
Category name:
cuny.is
Target version:
Start date:
2021-02-02
Due date:
% Done:

0%

Estimated time:

Description

I went to a group of mine (https://commons.gc.cuny.edu/groups/cunydhi/) and saw the notice about the need to complete the group metadata settings. So I clicked on the link and I was brought the group > manage page. I filled out the campus and purpose fields, and clicked save. When I did, I was brought to a screen with an error message about the group URL (see attached), which I do not think I changed. It does seem like the campus/purpose settings were recorded, but I'm not certain.

History

#1 Updated by Boone Gorges 9 months ago

  • Category name set to cuny.is
  • Status changed from New to Reporter Feedback

One problem here is that we should not be pinging cuny.is for shortlink availability if the admin hasn't changed the value. I've implemented this in https://github.com/cuny-academic-commons/cac/commit/48bd569306c5bf033d6f772749f8529fe260ef77.

For this specific group, there's a further problem. It appears that the cuny.is/cunydhi-group shortlink points to commons.gc.cuny.edu/groups/digital-humanities-initiative, while the URL of the group in question is commons.gc.cuny.edu/groups/cunydhi. As such, our YOURLS client thinks that the requested URL is already taken by another group. But the digital-humanities-initiative URL redirects to cunydhi. How did this happen? Matt, do you recall changing this at some point, or requesting that I do it? If this is a one-off, it may not be worth fixing. If there's a systematic way one can change group URLs, then perhaps it'll be possible to add some logic to the YOURLS integration that will handle these changes.

#2 Updated by Matt Gold 9 months ago

Hi Boone, I don't have a specific memory of this, but I think it's likely that I made that change manually.

#3 Updated by Boone Gorges 9 months ago

Thanks, Matt. Ray, do you have a memory of having the edit-group-slug plugin at some point? I'm trying to determine whether we need further action here.

#4 Updated by Raymond Hoh 9 months ago

Some historical context can be found in https://redmine.gc.cuny.edu/issues/8929#note-16.

We decided to remove bp-edit-group-slug further down the thread in https://redmine.gc.cuny.edu/issues/8929#note-21. And fully removed the plugin in #9717.

#5 Updated by Boone Gorges 9 months ago

  • Status changed from Reporter Feedback to Staged for Production Release
  • Target version set to 1.18.4

Aha, thanks for the digging, Ray!

It sounds likely that Matt had changed the group slug at some point in the past, then. I'm still not totally sure why there's a redirect between the old group URL and the new one. Nice feature, but I don't remember building it :)

Anyway, I think it's probably not worth digging into more, because it's no longer possible for users to change slugs.

#6 Updated by Boone Gorges 9 months ago

  • Status changed from Staged for Production Release to Resolved

Also available in: Atom PDF