Support #15151
closedCommons Main Navigation does not show which tab you are on
0%
Description
I guess this is a design question. It seems to me that, for example, if you are on the Groups tab, that list item should have some indication that you are there.
Files
Updated by Colin McDonald almost 3 years ago
- Assignee changed from Michael Smith to Sara Cannon
Hi Scott, just changing the assignee here to Sara and adding a couple of watchers. Sara, what do you think? Scott seems to mean something (like a background shading, or even just an underline) in the top nav items when you've clicked through to one of those items.
Updated by Sara Cannon over 2 years ago
What if we did a simple underline like https://capture.dropbox.com/CYk72DxAMAnG3xNv
Updated by Colin McDonald over 2 years ago
I like that - Scott, what do you think?
Updated by Boone Gorges over 2 years ago
- File Screenshot_2022-04-06_15-07-31.png Screenshot_2022-04-06_15-07-31.png added
- Status changed from New to Staged for Production Release
- Target version set to 1.19.7
I've added the underline in https://github.com/cuny-academic-commons/cac/commit/70ad4c018be881f6ed8bda7e45fa58a6ed9becec, https://github.com/cuny-academic-commons/cac/commit/4e6c799134b378e85071d7740ab10285c1e38cbd
The mobile menu looks different. For technical reasons, it's very difficult to add an underline to mobile menu items that is only the width of the word. For that reason, I decided on a full-width blue line. Screenshot attached - let me know if this needs to be rethought.
Updated by Colin McDonald over 2 years ago
Thanks Boone, and that seems fine to me on the long/uniform mobile line.
Updated by Boone Gorges over 2 years ago
- Status changed from Staged for Production Release to Resolved