Project

General

Profile

Support #15151

Commons Main Navigation does not show which tab you are on

Added by scott voth 5 months ago. Updated about 1 month ago.

Status:
Resolved
Priority name:
Normal
Assignee:
Sara Cannon
Category name:
Design
Target version:
1.19.7
Start date:
2022-01-05
Due date:
% Done:

0%

Estimated time:

Description

I guess this is a design question. It seems to me that, for example, if you are on the Groups tab, that list item should have some indication that you are there.

Screenshot_2022-04-06_15-07-31.png (15.5 KB) Screenshot_2022-04-06_15-07-31.png Boone Gorges, 2022-04-06 11:10 AM

History

#1 Updated by Colin McDonald 5 months ago

  • Assignee changed from Michael Smith to Sara Cannon

Hi Scott, just changing the assignee here to Sara and adding a couple of watchers. Sara, what do you think? Scott seems to mean something (like a background shading, or even just an underline) in the top nav items when you've clicked through to one of those items.

#2 Updated by Sara Cannon about 2 months ago

What if we did a simple underline like https://capture.dropbox.com/CYk72DxAMAnG3xNv

#3 Updated by Colin McDonald about 2 months ago

I like that - Scott, what do you think?

#4 Updated by scott voth about 2 months ago

Yes that seems like a good solution.

#5 Updated by Boone Gorges about 2 months ago

I've added the underline in https://github.com/cuny-academic-commons/cac/commit/70ad4c018be881f6ed8bda7e45fa58a6ed9becec, https://github.com/cuny-academic-commons/cac/commit/4e6c799134b378e85071d7740ab10285c1e38cbd

The mobile menu looks different. For technical reasons, it's very difficult to add an underline to mobile menu items that is only the width of the word. For that reason, I decided on a full-width blue line. Screenshot attached - let me know if this needs to be rethought.

#6 Updated by Colin McDonald about 2 months ago

Thanks Boone, and that seems fine to me on the long/uniform mobile line.

#7 Updated by Boone Gorges about 1 month ago

  • Status changed from Staged for Production Release to Resolved

Also available in: Atom PDF