Bug #17850
closedSearch not working
0%
Description
Hi Ray -- I'm getting a strange error when I try to search the Commons. Please see the attached screenshots.
To replicate:
- go to the CAC
- click the magnifying glass icon
- enter a term to search
Files
Related issues
Updated by Raymond Hoh about 1 year ago
- Category name set to Search
- Status changed from New to Resolved
- Target version set to 2.1.3
It looks like Google has deprecated using an <iframe> to display custom search results: https://support.google.com/programmable-search/answer/2631042.
The new method is using the Programmable Search Element: https://developers.google.com/custom-search/docs/tutorial/implementingsearchbox. I've updated our Google search code to use this new syntax. See https://github.com/cuny-academic-commons/cac/commit/aa8097a582421a49919178e446ac5ad8a02f7d32. I've also deployed this as a hotfix to production, so Google search is working again.
However, the look and feel needs to be configured on the Google side. I'm not sure who configured the original Google Custom Search Engine (Boone, Matt, or Scott?), but someone will need to configure the styles and colors. See https://developers.google.com/custom-search/docs/ui#designing-the-results for more info.
Updated by Matt Gold about 1 year ago
I don't remember how this was set up originally. Judging by this 12-year-old ticket (https://redmine.gc.cuny.edu/issues/125), perhaps it was Cast Iron Coding originally? In any case, I'd have to imagine that Boone took control of it at some point. This is not super pressing, though, and can definitely wait until he's back.
Updated by Boone Gorges about 1 year ago
Thanks, Ray!
I do have access to customize the Programmable Search Engine. I made some minor changes to the colors and fonts. I'm not seeing them reflected on the Commons, but perhaps it's cached. I'll circle back around.
Updated by Raymond Hoh 3 months ago
- Related to Bug #19621: Search functionality broken on Mobile added