Bug #18016
openml-slider get_plugins() call causes performance issues
Added by Boone Gorges over 1 year ago. Updated 9 days ago.
0%
Description
See discussion at https://redmine.gc.cuny.edu/issues/15767#note-2 and follow-up. The ml-slider folks have promised to fix the issue, but have not done so. https://wordpress.org/support/topic/call-to-get_plugins-causing-performance-problems/
Until they do, we will need to patch ml-slider each time it's updated. This happens next in the 2.1.5 release.
We should also have some sort of system for notifying the release manager (ie me) whenever this patch needs to be applied. Looking at GitHub Actions results is already part of my workflow, which helps me catch invalid syntax and other items. But this one is kinda hard to catch with static analysis tools. Instead, I'm thinking I'll add something to the wp-cli-cac script that I use for bulk plugin updates, something that throws a huge notice about plugins that need manual attention after they've received an update.
Related issues
Updated by Boone Gorges over 1 year ago
- Related to Support #15767: Site loading slowly added
Updated by Boone Gorges over 1 year ago
- Target version changed from 2.1.5 to 2.1.6
I've manually applied the patch for this release.
I've got a tentative fix in my wp-cli-cac tool that will generate a warning when ml-slider is updated: https://github.com/cuny-academic-commons/wp-cli-cac/commit/5b61e22af11ff532aff22b0d50b1b52427d62642 I'll test this with my next set of updates.
Updated by Boone Gorges over 1 year ago
- Status changed from New to Hold
- Target version changed from 2.1.6 to 2.1.7
Waiting for another release before closing this ticket. See https://redmine.gc.cuny.edu/issues/18098#note-7 for more information.
Updated by Boone Gorges over 1 year ago
- Related to Bug #18098: Disable NextGen Gallery's cache tracker added
Updated by Boone Gorges over 1 year ago
- Target version changed from 2.1.7 to 2.1.8
There was a slight error in my script that warns about updates to ml-slider. I caught it and was able to manually patch. I'll push this to the next release so that I can monitor again.
Updated by Boone Gorges over 1 year ago
- Target version changed from 2.1.8 to 2.1.9
Updated by Boone Gorges over 1 year ago
- Target version changed from 2.1.9 to 2.1.10
Updated by Boone Gorges over 1 year ago
- Related to Bug #18417: Call to undefined function is_plugin_active() added
Updated by Boone Gorges over 1 year ago
- Target version changed from 2.1.10 to 2.1.11
Updated by Boone Gorges over 1 year ago
- Target version changed from 2.1.11 to 2.1.12
Updated by Boone Gorges over 1 year ago
- Target version changed from 2.1.12 to 2.1.13
Updated by Boone Gorges over 1 year ago
- Target version changed from 2.1.13 to 2.1.14
Updated by Boone Gorges about 1 year ago
- Target version changed from 2.1.14 to 2.1.15
Updated by Boone Gorges about 1 year ago
- Target version changed from 2.1.15 to 2.1.16
ml-slider was updated in the most recent round of updates and the fixes still have not been implemented upstream. I'm afraid I forgot to check whether my CLI tool warning showed properly during the update process, so I'm going to continue to push this ticket. I've applied the necessary hotfixes in https://github.com/cuny-academic-commons/cac/commit/b69c5196dc51f4cc630927e37fc69b205d22966d for the time being.
Updated by Boone Gorges about 1 year ago
- Target version changed from 2.1.16 to 2.2.1
Updated by Boone Gorges about 1 year ago
- Target version changed from 2.2.1 to 2.2.2
Updated by Boone Gorges about 1 year ago
- Target version changed from 2.2.2 to 2.2.3
Updated by Boone Gorges 12 months ago
- Target version changed from 2.2.3 to 2.2.4
Updated by Boone Gorges 12 months ago
- Target version changed from 2.2.4 to 2.2.5
Updated by Boone Gorges 11 months ago
- Target version changed from 2.2.5 to 2.2.6
Updated by Boone Gorges 11 months ago
- Target version changed from 2.2.6 to 2.3.1
Updated by Boone Gorges 10 months ago
- Target version changed from 2.3.1 to 2.3.2
Updated by Boone Gorges 9 months ago
- Target version changed from 2.3.2 to 2.3.3
Updated by Boone Gorges 9 months ago
- Target version changed from 2.3.3 to 2.3.4
Updated by Boone Gorges 8 months ago
- Target version changed from 2.3.4 to 2.3.5
Updated by Boone Gorges 8 months ago
- Target version changed from 2.3.5 to 2.3.6
The authors still have not fixed the issues. Hotfix applied in https://github.com/cuny-academic-commons/cac/commit/ed8ab02bbcdf3a3357ba939471f9ca7fd13bfe32
Updated by Boone Gorges 7 months ago
- Target version changed from 2.3.6 to 2.3.7
Updated by Boone Gorges 6 months ago
- Target version changed from 2.3.7 to 2.3.8
Updated by Boone Gorges 5 months ago
- Status changed from Hold to Staged for Production Release
Still broken upstream. Hotfix applied in https://github.com/cuny-academic-commons/cac/commit/08bf489faf34f431ed66cb479ec745418ebf5e83
Updated by Boone Gorges 5 months ago
- Status changed from Staged for Production Release to Resolved
Updated by Boone Gorges 5 months ago
- Status changed from Resolved to Hold
- Target version changed from 2.4.1 to 2.4.2
Updated by Boone Gorges 5 months ago
- Target version changed from 2.4.2 to 2.4.3
Updated by Boone Gorges 4 months ago
- Target version changed from 2.4.3 to 2.4.4
Updated by Boone Gorges 3 months ago
- Target version changed from 2.4.4 to 2.4.5
Updated by Boone Gorges 3 months ago
- Target version changed from 2.4.5 to 2.4.6
Hotfixes reapplied after most recent update: https://github.com/cuny-academic-commons/cac/commit/ff68a14ba52a540c7af0fa52567633f5cafe1c75
Updated by Boone Gorges 2 months ago
- Target version changed from 2.4.6 to 2.4.7
Updated by Boone Gorges about 2 months ago
- Target version changed from 2.4.7 to 2.4.8
Updated by Boone Gorges about 1 month ago
- Target version changed from 2.4.8 to 2.4.9
Updated by Boone Gorges about 1 month ago
- Target version changed from 2.4.9 to 2.4.10
Updated by Boone Gorges 9 days ago
- Target version changed from 2.4.10 to 2.4.11