Bug #1845
closedEmail notification of forum-reply-by-email contains wrong post text
0%
Description
Here's the setup:
1. A and B are in the same group, with email notifications set to All Mail
2. A starts a new forum topic using the web interface.
3. Email notification automatically goes to B
4. B replies to the forum topic by replying to the email
5. The reply is correctly posted to the database, and shows up properly in the web interface, and posts the correct content to the activity stream.
The problem is this: the email notification that A receives of this reply contains the wrong body text. (The email header "B posted on the forum topic 'Foo'...) and the footer links are all correct.)
This is almost certainly due to a problem with the custom function cac_full_forum_notification() in bp-custom.php, which is intended to swap out the text of the default email sent by BP Group Email Subscription with the full text of the forum post. It appears, at a glance, that the activity item being passed to the filter is incorrect.
Ray, since the email notifications work properly when replying through the web interface, I'm guessing this is a problem with the way that RBE is firing the action/filter. Would you mind taking a look please? If it turns out to be a problem on my end (BPGES or cac_full_forum_notification()), you can reassign the ticket to me (if you don't feel like fixing it yourself). Thanks!
Updated by Boone Gorges over 12 years ago
- Assignee changed from Raymond Hoh to Boone Gorges
I decided to take five minutes and look myself, instead of being lazy :)
Turns out that you were setting secondary_item_id to $topic_id (in bp_rbe_groups_new_group_forum_post()), rather than $post_id, as it is in groups_new_group_forum_post(). So the activity parser in BP GES was getting confused.
I've fixed it in the CAC repo at https://github.com/castiron/cac/commit/eb4768b7aedf233871044487021296041facd30f Going to push a change to the plugin repo in a minute.
Updated by Raymond Hoh over 12 years ago
Good catch, Boone! :) Helps to have another set of eyes!
Updated by Raymond Hoh about 12 years ago
- Status changed from Assigned to Resolved
Boone fixed this awhile ago!