Project

General

Profile

Actions

Bug #19320

closed

Forum post quotation block quote format button leads to HTML code in Visual editor

Added by Matt Gold 3 months ago. Updated 3 months ago.

Status:
Resolved
Priority name:
Normal
Assignee:
Category name:
Group Forums
Target version:
Start date:
2023-11-21
Due date:
% Done:

0%

Estimated time:
Deployment actions:

Description

Hi Ray --

I was writing a post for my class in a group forum using the Visual Editor, and wanted to put some of my content in a quotation/block quote. I selected text, then hit the quotation mark icon in the formatting toolbar. Doing so seemed to insert paragraph HTML tags in the resulting post. i've attached photos of the way the posts looks in the forum and via the email notification

it also looks like the line breaks rendered correctly in the email notification, but not in the BbPress version of the post


Files

Screenshot 2023-11-21 at 6.39.01 PM.png (433 KB) Screenshot 2023-11-21 at 6.39.01 PM.png bbpress forum post Matt Gold, 2023-11-21 06:40 PM
Screenshot 2023-11-21 at 6.39.15 PM.png (256 KB) Screenshot 2023-11-21 at 6.39.15 PM.png email notification (shown in Gmail) Matt Gold, 2023-11-21 06:40 PM
Actions #1

Updated by Raymond Hoh 3 months ago

  • Category name set to Group Forums
  • Status changed from Assigned to Staged for Production Release
  • Target version set to 2.2.3

If you look at the screenshots, you will notice the <p dir="auto"> attribute in the forum posts. My guess is the visual editor is adding the <p dir="auto"> attribute during pastes. The dir="auto" part is not allowed in bbPress by default, so bbPress disallows the entire paragraph tag as a result and renders the triangle brackets instead.

To address this, we can tell bbPress to allow the <p dir="XXX"> attribute and this will let bbPress render these paragraphs correctly. See https://github.com/cuny-academic-commons/cac/commit/05b4f9cd12ad1383d8a8c0db2c38481dc668624f . This will be part of next Tuesday's release. Unfortunately, this will not fix existing forum posts with this problem.

You will need to edit the forum posts and use the "Text" tab to manually fix up the text by replacing:

&lt;p dir="auto"&gt;

with:

<p>

Let me know if you need some help with this.

Actions #2

Updated by Matt Gold 3 months ago

Thanks so much, Ray!

Actions #3

Updated by Boone Gorges 3 months ago

  • Status changed from Staged for Production Release to Resolved
Actions

Also available in: Atom PDF