Bug #19529: Commons CV Cover Image Caption - CUNY Academic Commons - CUNY Graduate Center - Project Tracking System

Actions

Copy link

Bug #19529

closed

Commons CV Cover Image Caption

Added by Sara Cannon 10 months ago. Updated 10 months ago.

Status:

Resolved

Priority name:

Normal

Assignee:

Jeremy Felt

Category name:

Target version:

2.3.1

Start date:

2024-01-15

Due date:

% Done:

Estimated time:

Deployment actions:

Description

I uploaded my own cover image and added a caption/credit. When I decided to replace the image with a Commons art banner, the caption I had previously added was still there.

Whenever a user selects a commons default art banner, can the cover image caption prefill and/or overwrite with credit to Ryan Seslow?

Actions

Copy link

Updated by Boone Gorges 10 months ago

Assignee changed from Boone Gorges to Jeremy Felt
Target version set to 2.3.1

Good catch!

Whenever a user selects a commons default art banner, can the cover image caption prefill and/or overwrite with credit to Ryan Seslow?

I think the correct behavior would be to clear this field, and then allow it to be re-prefilled with 'Ryan Seslow' if the user then selects a default image.

Actions

Copy link

Updated by Colin McDonald 10 months ago

That seems right to me. If the cover image is changed, we should remove any caption that is there. But for any default Commons image chosen, it should say "Credit: Ryan Seslow" in the caption.

I just checked on CDEV, and if I have a custom image with a caption, then I hit Replace and upload a new custom image, it still retains the caption. It seems to me that whenever one hits Replace the caption field should be emptied.

Actions

Copy link

Updated by Jeremy Felt 10 months ago

It seems to me that whenever one hits Replace the caption field should be emptied.

I just pushed a change to the 2.3.x branch that empties the caption whenever "Replace" is clicked.

Almost there with the credit to Ryan Seslow. Fixing this uncovered another issue with the selected banner workflow.

Actions

Copy link

Updated by Jeremy Felt 10 months ago

I've just pushed another change to the 2.3.x branch that adds a credit for Ryan Seslow to any default banner and tracks state for the banner type so that the correct modal appears when a user replaces the existing image.

Actions

Copy link