Bug #19611
closedFormatting Issues on New Cv
0%
Description
Hi All,
A message from a Commons user. Sounnds like his CV was migrated correctly at first but somehow the formatting and html was messed up in later updates:
Hi Commons Team,
I noticed today that all of the html markup (links, formatting, etc.) got lost on my profile page:
Cp. 2022 version: https://web.archive.org/web/20221101000000*/https://commons.gc.cuny.edu/members/jbretmaney/
It had looked really nice after the initial Commons facelift. I assume this loss of the markup occurred at a later stage in that process. Do you know if that markup will be recovered? If not, should I go ahead and reformat the profile now or is the dev team still making tweaks to this part of the site?
Updated by Boone Gorges 10 months ago
I can regenerate the CV and try to diagnose what happened. Can the user confirm that they haven't made any manual changes to it in the last 7-10 days? (I may not be able to get to this until Monday, so please ask the user not to make any changes until then so that I don't wipe them out.)
Updated by Laurie Hurson 10 months ago
Sounds good, thanks Boone! I will let him know.
Updated by Boone Gorges 10 months ago
- Status changed from New to Reporter Feedback
- Target version set to 2.3.2
Thanks for your patience. I was able to isolate the issue. Part of the CV migration script was designed to strip out <br> tags. But there was an issue with the technique used, such that inline elements like links could be lost in certain cases during the process.
I've updated the migration tool in https://github.com/cuny-academic-commons/cac/commit/920e824b29503609bcd2396cb535a2baef296509 to account for this. Then, I added some logic to the migration tool so that it's now a migration-and-repair tool. The new logic is: If a CV exists for a user, check to see whether the user has updated the CV since its original creation or my subsequent fixes. We can do this by looking at each CV object's revisions: if it has any revisions that are authored by the CV owner, this means that the user has updated it. If the user has not updated the CV, then it's safe to fix. Then, after a test, I ran the script across the network.
The user's CV now has all the intended formatting: https://commons.gc.cuny.edu/members/jbretmaney/
Updated by Laurie Hurson 10 months ago
Thanks for looking into this and resolving, Boone! The CV looks correct, I will let the user know.
And sounds like the new migration & repair tool will be helpful across the network. Thanks again!
Updated by Laurie Hurson 10 months ago
Hi All,
Following with another issue identified by this user:
"Just an update. I noticed that the developers were able to regenerate the CV content, which is great. When I tried to make an edit today, however, it looked like this. Attempting block recovery appears to delete the content. I wonder if this is reproducible for others' cvs?"
I was able to reproduce this issue. When I first tried to edit my CV settings, many blocks were erased when I tried to recover content.
Is this a bug?
Thanks!
Updated by Boone Gorges 10 months ago
Thanks for the report.
Part of the issue was related to a problem with the Positions block. The issue was reported in #19550 and I fixed it at that time, but when applying subsequent formatting fixes here, the fix got partially overwritten. I wrote a script to do a proper correction.
The CV at https://commons.gc.cuny.edu/members/jbretmaney had an additional issue in its 'Publications' section, which had to do with invalid markup in the original profile that was not properly caught by the migration tool. Unfortunately, the Block Editor's "resolve" tool was not smart enough to handle it. So I manually modified the content of the post to fix that bit of markup, and that CV appears to be working properly.
Updated by Laurie Hurson 10 months ago
Thanks for the quick fix! I let the user know
Updated by Boone Gorges 9 months ago
- Status changed from Reporter Feedback to Resolved