Project

General

Profile

Actions

Bug #19944

closed

Dealing with BuddyPress 12.x upgrade, pt. 2

Added by Raymond Hoh 2 months ago. Updated 27 days ago.

Status:
Resolved
Priority name:
Normal
Assignee:
Category name:
BuddyPress (misc)
Target version:
Start date:
2024-03-11
Due date:
% Done:

0%

Estimated time:
Deployment actions:

git submodule update
wp rewrite flush
wp plugin deactivate bp-classic


Description

Follow-up to #19493. Just wanted to make sure my comments in https://redmine.gc.cuny.edu/issues/19493#note-10 are brought forward to a future release:

For more pronounced changes, I created a new branch -- bp12-part2 -- that namely switches out all BuddyPress 12 deprecated function calls. We can roll that out in a later maintenance release.

I've been testing bp12-part2 with BP Classic deactivated and with BP_IGNORE_DEPRECATED set to true and these are some issues I encountered:

About the bbPress load order issue:

Furthermore, when running bp-classic, I had to do some additional work to ensure that bbPress's BP compatibility layer is loaded in time, and is loaded only once. Like the approach above, it's pretty hacky (requiring a static variable to prevent double-loading) but it basically works. Here's the full patch: https://github.com/openlab-at-city-tech/openlab/commit/27f2a68354550295d85f0f3c5aaafc55004268f0

I tackled this a little differently in my bbPress commit. See https://github.com/cuny-academic-commons/cac/commit/e2145f2462d3d2cbe2f16de914e7875c48b6e1cc#diff-0f345898d2c7666be77acc95ec88e90e98a407644a4ce5431b3fb96d06749039 and the constructor and includes() portion of https://github.com/cuny-academic-commons/cac/commit/e2145f2462d3d2cbe2f16de914e7875c48b6e1cc#diff-a8d1ad6e40805411d0e557ee641e9d47c6cc3d0f17ef107f22ac729255439a5a . I think the constructor changes might fix your double load order issue. Can you do some tests and see if this works for you, Boone?

This doesn't need to go in tomorrow's 2.3.4 release. Let's put this in 2.3.5 or later.


Related issues

Related to CUNY Academic Commons - Feature #19493: Dealing with BuddyPress 12.x upgradeResolvedBoone Gorges2024-01-05

Actions
Related to CUNY Academic Commons - Bug #20309: "Create a Site" Link from profile picture is brokenResolvedRaymond Hoh2024-05-06

Actions
Actions #1

Updated by Raymond Hoh 2 months ago

  • Related to Feature #19493: Dealing with BuddyPress 12.x upgrade added
Actions #2

Updated by Boone Gorges 2 months ago

  • Target version set to 2.3.5

Thanks for opening the ticket, Ray. I'll do some testing in the upcoming week or two.

Actions #3

Updated by Boone Gorges about 2 months ago

  • Target version changed from 2.3.5 to 2.3.6

I didn't get a chance to review this so I'm going to bump.

Actions #4

Updated by Boone Gorges 27 days ago

  • Status changed from New to Staged for Production Release
  • Deployment actions updated (diff)

I've done some testing and these changes are looking good. Let's go for it in tomorrow's release.

Actions #5

Updated by Boone Gorges 27 days ago

  • Status changed from Staged for Production Release to Resolved
Actions #6

Updated by Raymond Hoh 13 days ago

  • Related to Bug #20309: "Create a Site" Link from profile picture is broken added
Actions

Also available in: Atom PDF