CUNY Academic Commons

Follow-up to #19493. Just wanted to make sure my comments in https://redmine.gc.cuny.edu/issues/19493#note-10 are brought forward to a future release:

For more pronounced changes, I created a new branch -- bp12-part2 -- that namely switches out all BuddyPress 12 deprecated function calls. We can roll that out in a later maintenance release.

I've been testing bp12-part2 with BP Classic deactivated and with BP_IGNORE_DEPRECATED set to true and these are some issues I encountered:

• BP Event Organiser needs some minor adjustments to account for group subnav registration: https://github.com/cuny-academic-commons/bp-event-organiser/compare/1.2.x...bp12#diff-b0397cc71e95a79af968e8dadb7b8e525085f462c5a88ac11c8bdb86ecd7173d
• bbPress does some conditional checks that needs to be delayed to the 'bp_parse_query' hook. This fixes an issue with the bbPress stylesheet not loading on group forum pages I mentioned above in comment 4 amongst other permission-related cap overrides for the current user.
• I need Git permissions to the tapor-client repo so I can push changes and pin a new version for our cac repo.

About the bbPress load order issue:

Furthermore, when running bp-classic, I had to do some additional work to ensure that bbPress's BP compatibility layer is loaded in time, and is loaded only once. Like the approach above, it's pretty hacky (requiring a static variable to prevent double-loading) but it basically works. Here's the full patch: https://github.com/openlab-at-city-tech/openlab/commit/27f2a68354550295d85f0f3c5aaafc55004268f0

I tackled this a little differently in my bbPress commit. See https://github.com/cuny-academic-commons/cac/commit/e2145f2462d3d2cbe2f16de914e7875c48b6e1cc#diff-0f345898d2c7666be77acc95ec88e90e98a407644a4ce5431b3fb96d06749039 and the constructor and includes() portion of https://github.com/cuny-academic-commons/cac/commit/e2145f2462d3d2cbe2f16de914e7875c48b6e1cc#diff-a8d1ad6e40805411d0e557ee641e9d47c6cc3d0f17ef107f22ac729255439a5a . I think the constructor changes might fix your double load order issue. Can you do some tests and see if this works for you, Boone?

This doesn't need to go in tomorrow's 2.3.4 release. Let's put this in 2.3.5 or later.