Project

General

Profile

Actions

Support #2039

closed

Create Failure function for RBE

Added by Matt Gold about 10 years ago. Updated about 10 years ago.

Status:
Resolved
Priority name:
Normal
Assignee:
Category name:
BuddyPress (misc)
Target version:
Start date:
2012-08-12
Due date:
% Done:

0%

Estimated time:

Description

Per ticket 2035 :

(from Boone):

On a related note, Ray and I talked yesterday about how senders aren't notified when their replies aren't posted by RBE. He plans to have a look at implementing some failure messages ("We don't recognize your email address", "Your formatting can't be parsed", stuff like that), which will go some way to helping this problem. That is, in the future folk like George will get a message back saying "Sorry, we couldn't post your message, because of some formatting issues. Make sure you have left your reply above the line, and that you haven't deleted the line. See http://some.support.page for more information."


Files

RBE_-_Failure_messages.rtf (8.13 KB) RBE_-_Failure_messages.rtf Raymond Hoh, 2012-08-17 06:12 AM
Actions #1

Updated by Boone Gorges about 10 years ago

  • Target version changed from 1.4.1 to 1.4.2
Actions #2

Updated by Boone Gorges about 10 years ago

  • Target version changed from 1.4.2 to 1.4.3
Actions #3

Updated by Raymond Hoh about 10 years ago

Okay, I've implemented this in commit f14e923 .

I've attached a document containing all failure messages. I've tried to keep it generic for the purposes of the plugin. Let me know if the verbiage should be altered. If we need to input any support links or whatnot, let me know and I'll figure out a way to make it generic or filterable.

This commit also adds some checks I missed like user spammer check, forum thread exists check, and PM thread checks.


I've also added some code to record meta whenever a RBE forum post or activity item is made.

This makes it possible to display a RBE marker for forum posts in a group forum topic.

eg.

For the email icon, I just piggybacked off Group Email Subscription's existing styles.

This should take effect for new RBE forum posts.

Actions #4

Updated by Boone Gorges about 10 years ago

Hi Ray,

The commit looks great. One niggle: for incorrect addresses, can we expunge the extra "from"?

...make sure to reply using the same email address at which you received the original notification from.

I pulled these latest changes to cdev, and reactivated the plugin. I'm tailing wp-content/bp-rbe-debug.log, and I can see when emails from incorrect addresses are coming in and getting blocked, but the error emails are being sent. Successful RBE emails are going out correctly, so email is working more generally. Could you have a look and see if I've overlooked something?

Love the "via email" bit :)

Actions #5

Updated by Raymond Hoh about 10 years ago

Hi Boone,

I'm tailing wp-content/bp-rbe-debug.log, and I can see when emails from incorrect addresses are coming in and getting blocked, but the error emails are being sent. Successful RBE emails are going out correctly, so email is working more generally. Could you have a look and see if I've overlooked something?

I made it a conscious choice to not log outgoing failure messages in bp-rbe-debug.log. Although, I believe I should now that you've talked me into it :)

Is this what you mean? If not, let me know!

Actions #6

Updated by Boone Gorges about 10 years ago

Shoot. I meant "but the error emails are NOT being sent". Not sure how to debug that :)

Actions #7

Updated by Raymond Hoh about 10 years ago

What failure type did you try? (User doesn't exist, etc.)

I'll take a look on cdev.

Actions #8

Updated by Boone Gorges about 10 years ago

Specifically, I tried user doesn't exist (responding with to a notification sent to ).

Actions #9

Updated by Raymond Hoh about 10 years ago

Just tried the user doesn't exist failure type and I received the email notification at an alternate email address (Google Apps Mail FWIW).

Did you check your spam folder? If not, can you try again?

Actions #10

Updated by Raymond Hoh about 10 years ago

Update: Ah-ha!

I looked closer at the bp-rbe-debug.log and is already a valid user but is not a member of the group or banned.

My parsing logic doesn't send failure emails for members who are not a member of a group or a banned group user. That's why you weren't receiving the failure email!

I probably should send failure emails for users who are not a member of a group. Banned users shouldn't receive any failure emails as it's currently implemented.

What do you think?

Actions #11

Updated by Boone Gorges about 10 years ago

Aha! Good find, Ray.

I guess the ideal situation would be that the reply-to hashes were user-specific. That way, the only address that can respond to a given notification is the user to whom it was originally sent.

If that's too difficult to implement, a group check would be more than enough. That'll mean that users can't join public groups by posting to them, as they can in the web interface, but that seems OK, since they won't be getting the RBE notification in the first place.

Actions #12

Updated by Raymond Hoh about 10 years ago

The capability to add user-specific hashes is already in RBE. See the hash used for members posting new group forum topics via email as an example.

However, for "Reply-To" emails, this isn't. Doing so will add an extra DB lookup to grab their user ID to add to the hash before sending each email. Might have to reconfigure parts of the codebase to make it work as well.

I think if we run into issues with spam, I can revisit this.

Did we want to send a failure email for users who are not a member of a group? Could be useful if a user decides to manually leave a group, but decided to reply to an older email?

Actions #13

Updated by Boone Gorges about 10 years ago

I think if we run into issues with spam, I can revisit this.

Sounds good.

Did we want to send a failure email for users who are not a member of a group? Could be useful if a user decides to manually leave a group, but decided to reply to an older email?

Yes, if it's not too much trouble. We don't want to allow behavior over email (such as posting to a private group where one is not a member) that we don't allow on the site.

Actions #14

Updated by Raymond Hoh about 10 years ago

Part of commit 8ed8a2e adds failure emails for users who are not a member of a group.

If there aren't any other use cases, I think we can mark this issue as resolved!

Actions #15

Updated by Boone Gorges about 10 years ago

  • Status changed from Assigned to Resolved

Looks bodacious. Thanks, Ray!

Actions

Also available in: Atom PDF