Project

General

Profile

Actions

Support #21013

closed

Question about group library file editing permissions

Added by Matt Gold 23 days ago. Updated 17 days ago.

Status:
Rejected
Priority name:
Normal
Assignee:
-
Category name:
Group Library
Target version:
-
Start date:
2024-09-18
Due date:
% Done:

0%

Estimated time:
Deployment actions:

Description

I just tried to edit a file in a group library but was unable to. Here is the scenario:

  • I am co-teaching a class (with Krysia). She uploaded files to our group library. I believe she did this by cloning a previous group, but I'm not certain (though I could ask if this is important). We are both admins of the group ( https://commons.gc.cuny.edu/groups/introduction-to-digital-humanities-fall-2024 )
  • I noticed that one of the PDFs Krysia uploaded was not OCRed. So, I OCRed it and wanted to replace the existing file
  • When I look at the group library, there is no option for me to edit any of the files, presumably because I did not upload them.
  • When I look at group settings, there is no way for me to edit files
So, two questions, one practical and one for discuss:
  • Is the group library the place where one can edit files after they've been uploaded? (as opposed to group settings?)
  • do we think that only the person who uploaded a file should be able to edit files in a given group? or should any group admin be able to edit any file in the group

I'd lean towards the second option given this use case, but I'd like to hear what others think


Files

Actions #1

Updated by Boone Gorges 23 days ago

The Edit item should be available to users who either (a) are network admins, or (b) are group admins. Item authorship is not taken into account at all. See the attached screenshot to see where the Edit button should appear. See https://github.com/cuny-academic-commons/cac-group-library/blob/b9d15c3f512e065d56ade216e7eb509b873a5248/assets/js/app/views/GroupLibrary.vue#L313, https://github.com/cuny-academic-commons/cac-group-library/blob/master/src/LibraryItem/Item.php#L365 Please confirm you're looking in the right place. If you still don't see the Edit button, I guess there's a bug somewhere in this implementation.

Note, though, that there are limitations to what can be done while editing an uploaded file. You can change the name of the library item, or its folders, but you cannot replace the uploaded file. We could consider adding this feature, though it's somewhat complex.

Actions #2

Updated by Matt Gold 17 days ago

Thank you, Boone. I complete missed that icon! Thanks for pointing it out. I see it now and can edit.

However, I was looking to replace the file. I suppose I could delete it and upload a new version, which is a reasonable workaround if replacing is too complex to be worth the work.

Actions #3

Updated by Boone Gorges 17 days ago

  • Status changed from Reporter Feedback to Rejected

Yes, it's a lot of work to build the replace-file feature, so let's set it aside for now.

Actions

Also available in: Atom PDF