Bug #2105
closedFile name in a file uploaded to group contains escape characters
Added by Matt Gold about 12 years ago. Updated about 12 years ago.
0%
Description
Please see attached screenshot
Files
| Screen_Shot_2012-09-06_at_3.11.07_AM.png (10.4 KB) Screen_Shot_2012-09-06_at_3.11.07_AM.png | Matt Gold, 2012-09-06 03:12 AM | ||
| group-file-upload-test.png (130 KB) group-file-upload-test.png | Dominic Giglio, 2012-09-30 12:45 PM | ||
| Screen_Shot_2012-10-04_at_2.31.38_AM.png (134 KB) Screen_Shot_2012-10-04_at_2.31.38_AM.png | Matt Gold, 2012-10-04 02:32 AM | ||
| Screen_Shot_2012-10-04_at_2.30.38_AM.png (126 KB) Screen_Shot_2012-10-04_at_2.30.38_AM.png | Matt Gold, 2012-10-04 02:32 AM |
Updated by Matt Gold about 12 years ago
Updated by Boone Gorges about 12 years ago
- Target version changed from 1.4.4 to 1.4.5
Updated by Dominic Giglio about 12 years ago
Matt,
I've never uploaded a file to our site. Could you tell me exactly the steps you took leading up to this error? Where did you upload the file, what kind of file was it, to which group did you upload it, etc? I want to see if I can reproduce it in my local dev environment.
Updated by Matt Gold about 12 years ago
Hi Dom --
Create/go to a group. Go to "Files". Upload file. Check out notification message and file listing on Files page
Updated by Boone Gorges about 12 years ago
- Target version changed from 1.4.5 to 1.4.6
Updated by Dominic Giglio about 12 years ago
- File group-file-upload-test.png group-file-upload-test.png added
- Target version changed from 1.4.6 to 1.4.7
Matt,
I'm moving this to 1.4.7 for now in favor of working on higher priority 1.4.6 issues.
But I did a little testing last night and haven't been able to exactly replicate your original issue.
I uploaded a bunch of different files to the test group I created for testing GES subscription status. I tried with a name, without a name, with a description, without a description and various types of filenames. You can see in the attached screen shot that the most recent document had quotes in the actual filename which caused the name to be escaped with "%22" at the beginning and the end.
I tried *.doc, *.txt, *.rtf and *.pdf and that didn't seem to matter. Can you tell me a little more about your specific file? What filetype was it? Did it have quotes in the name on your machine before you uploaded?
Also, you're screenshot doesn't look exactly like mine. Yours says "Matthew Gold, \"Digital Humanities\" (106.5k)" but my page lists the uploaded files as "FILENAME uploaded by humanshell on DATE." Am I not looking at the correct page? Could you get me a better screenshot that shows more of the page output?
Updated by Boone Gorges about 12 years ago
- Assignee changed from Boone Gorges to Dominic Giglio
Updated by Matt Gold about 12 years ago
- File Screen_Shot_2012-10-04_at_2.31.38_AM.png Screen_Shot_2012-10-04_at_2.31.38_AM.png added
- File Screen_Shot_2012-10-04_at_2.30.38_AM.png Screen_Shot_2012-10-04_at_2.30.38_AM.png added
Sure -- it's a PDF file that was uploaded to a group. Screenshots attached.
Updated by Dominic Giglio about 12 years ago
- Target version changed from 1.4.7 to 1.4.8
Updated by Dominic Giglio about 12 years ago
- Target version changed from 1.4.8 to 1.4.9
Updated by Dominic Giglio about 12 years ago
Boone,
If we're going to discuss a rewrite of the group-docs plugin can this issue be closed or maybe moved to Not Tracked for now? For the life of me I cannot reproduce this no matter what I do. If this plugin is going to be re-engineered, the problem described above may be taken care of automatically?
Updated by Boone Gorges about 12 years ago
- Status changed from Assigned to Resolved
This was a pretty straightforward fix, so I went ahead and did it. https://github.com/castiron/cac/commit/6823e550ce451b80be335410862cd057a1aef341
Updated by Dominic Giglio about 12 years ago
Oh, Son of a B!!
I ALWAYS forget to check bp-custom.php!! I keep forgetting that we have SO much custom code in there and cac-functions.php that I miss the easiest fixes. Thanks for taking care of this for me, it was really becoming annoying to stare at it and know that I just couldn't figure it out or reproduce it. :-)
Updated by Boone Gorges about 12 years ago
Ha. I actually had to look around a bit myself as well!