Include failed message in RBE Failure Notification
Just received the following error message from RBE:
Your reply could not be posted because we could not find the "--- Reply ABOVE THIS LINE to add a comment ---" marker in the body of your email.
In the future, please make sure you reply above this line for your comment to be posted on the site.
If you have any questions, please let us know.
Definitely great to be alerted to that, but it would be helpful if the failure message included the failed message or, at the least, the subject line of the failed message -- otherwise, it's difficult to know which message failed (especially if one uses RBE a lot)
#2 Updated by Raymond Hoh over 6 years ago
Thanks for noting about the user experience. I can definitely understand where you're coming from!
The error message you noted above only shows up when you're replying to activity updates.
Therefore, it's not possible to add a subject line since activity updates do not include subject lines.
Also, the reason why the body of the failed message isn't included is RBE could not detect one itself (and hence the failure email!). However, it might be possible to add the entire body of the email before RBE filters through it. Let me know what you think.
FYI, group forum replies have their own error message. This is what a forum reply failure message looks like:
Hi there, Your forum reply: "%s" Could not be posted because the forum topic you were replying to no longer exists. We apologize for any inconvenience this may have caused.
A full list of RBE error messages can be found in this document:
#4 Updated by Raymond Hoh over 6 years ago
That's odd; I checked the emails in question from CUNY's GMail account and they look fine.
I made a mistake in my previous comment. The error message you posted is used for all replies that do not have a properly-parsed body. So it may be possible to add a subject line to the error message.
One common thread between the failed emails is they are all quoted-printable encoded emails. So there might be a parsing bug in RBE with regards to this; I'm going to look into this and report back in the next day or so.
#6 Updated by Raymond Hoh over 6 years ago
Matt: Your use of Boomerang uncovered a bug with RBE's multipart email parser.
This should be fixed as of commit 96e0a04.
I've updated cdev with the new RBE code so you can try using Boomerang over there. Let me know what happens.
Note: I haven't addressed adding a subject line to failed messages yet though.
#10 Updated by Raymond Hoh over 6 years ago
Cdev can sometimes be a bit finicky with how WP cron jobs are fired; I just made sure the cron job on cdev started two minutes ago. So far, no new emails have appeared in the debug log.
Did you schedule an email to fire immediately in Boomerang? Or at a certain time?
Update: Just checked the inbox, your email was flagged as spam by GMail.
#14 Updated by Raymond Hoh over 6 years ago
I just unspammed the email and ran into one other RBE bug that I just fixed. Now, RBE parsed the Boomerang email successfully!
Regarding why the email was marked as spam, I see two things that might have triggered GMail's spam filter:
1) It could have been the contents of the email - "wat you talkin bout?"
2) It could have been the group permalink - "testy-test-960557098" as it looks spammy
But in both cases, that would be very aggressive spam targeting by GMail!
Perhaps try a more, email-like email? :)
It's something to definitely keep an eye on.
#16 Updated by Raymond Hoh over 6 years ago
Looks like after 1.4.5 was released, Boone forgot to deactivate / reactivate RBE; RBE needs to be reactivated when new code updates are made.
Matt: If you feel comfortable, since you are a super admin, you should be able to deactivate / activate plugins. If you don't feel comfortable, then Boone can handle this when he gets to it.
#18 Updated by Raymond Hoh over 6 years ago
Boone: I'm not too sure myself. It could be something to do with PHP running the codebase from memory and the pseudo-daemon never really finishes exiting the script.
Matt: Which email did you send? I don't see any problems in the log. I also logged in to GMail and noticed that there were six emails by you that were posted between this morning and now. Can you forward me the email in question so I can compare?
#20 Updated by Matt Gold over 6 years ago
ah, okay. Just posted another message but it hasn't come through yet -- presumably for the reason you noted above. Very glad the Boomerang issue is resolved!
Looking at this ticket, we've strayed a bit from the primary issue at hand. Is the failure message issue now resolved?
Thanks, as always, for your great work and your help.
#21 Updated by Raymond Hoh over 6 years ago
Cool, glad Boomerang works!
Yes, we definitely strayed from the original intent of the issue, but it was due to Boomerang finding a bug in RBE that caused the issue in the first place.
I can address the subject line for failed emails for 1.4.7 as originally intended.
#48 Updated by Raymond Hoh almost 6 years ago
Could use some feedback with the wording:
Hi there, Your reply could not be posted because we could not find the "--- Reply ABOVE THIS LINE to add a comment ---" marker in the body of your email. In the future, please make sure you reply *above* this line for your comment to be posted on the site. For reference, the subject line of your reply was "X". If you have any questions, please let us know.
X usually looks like this -
"Re: Ray replied to the topic Test Topic in the forum Test Forum [Site Name]"
Let me know what you think before I make this change.