Project

General

Profile

Bug #2116

Include failed message in RBE Failure Notification

Added by Matt Gold almost 7 years ago. Updated about 6 years ago.

Status:
Resolved
Priority name:
Normal
Assignee:
Category name:
BuddyPress (misc)
Target version:
Start date:
2012-09-10
Due date:
% Done:

100%

Estimated time:

Description

Just received the following error message from RBE:

Hi there,

Your reply could not be posted because we could not find the "--- Reply ABOVE THIS LINE to add a comment ---" marker in the body of your email.

In the future, please make sure you reply above this line for your comment to be posted on the site.

If you have any questions, please let us know.

Definitely great to be alerted to that, but it would be helpful if the failure message included the failed message or, at the least, the subject line of the failed message -- otherwise, it's difficult to know which message failed (especially if one uses RBE a lot)

History

#1 Updated by Matt Gold almost 7 years ago

Subject line of the message above was "Your Reply By Email message could not be posted [CUNY Academic Commons]"

#2 Updated by Raymond Hoh almost 7 years ago

Hi Matt,

Thanks for noting about the user experience. I can definitely understand where you're coming from!

The error message you noted above only shows up when you're replying to activity updates.

Therefore, it's not possible to add a subject line since activity updates do not include subject lines.

Also, the reason why the body of the failed message isn't included is RBE could not detect one itself (and hence the failure email!). However, it might be possible to add the entire body of the email before RBE filters through it. Let me know what you think.

FYI, group forum replies have their own error message. This is what a forum reply failure message looks like:

Hi there,

Your forum reply:

"%s" 

Could not be posted because the forum topic you were replying to no longer exists.

We apologize for any inconvenience this may have caused.

A full list of RBE error messages can be found in this document:
http://redmine.gc.cuny.edu/attachments/753/RBE_-_Failure_messages.rtf

#3 Updated by Matt Gold almost 7 years ago

Thanks, Ray. I had three messages fail today, but I think I know why. I just started using Boomerang for gmail (http://www.boomeranggmail.com/), which I think means that messages ultimately aren't being sent directly from my gmail account.

#4 Updated by Raymond Hoh almost 7 years ago

That's odd; I checked the emails in question from CUNY's GMail account and they look fine.

I made a mistake in my previous comment. The error message you posted is used for all replies that do not have a properly-parsed body. So it may be possible to add a subject line to the error message.

One common thread between the failed emails is they are all quoted-printable encoded emails. So there might be a parsing bug in RBE with regards to this; I'm going to look into this and report back in the next day or so.

#5 Updated by Matt Gold almost 7 years ago

Thanks, Ray. If you want me to forward the sent mail or failure messages to you, please let me know.

#6 Updated by Raymond Hoh almost 7 years ago

Matt: Your use of Boomerang uncovered a bug with RBE's multipart email parser.

This should be fixed as of commit 96e0a04.

I've updated cdev with the new RBE code so you can try using Boomerang over there. Let me know what happens.

Note: I haven't addressed adding a subject line to failed messages yet though.

#7 Updated by Raymond Hoh almost 7 years ago

Hi Matt, have you had a chance to test Boomerang with RBE on cdev?

The reason why I ask is the commit in this ticket is scheduled to be merged into 1.4.5.

Let me know! Thanks!

#8 Updated by Matt Gold almost 7 years ago

Sorry! I have not, in part because I was having a problem with Boomerang itself that was preventing me from testing. It's resolved now so I'll test and let you know. Apologies for the delay.

#9 Updated by Matt Gold almost 7 years ago

So far, at least: message didn't post through Boomerang. Nor did I receive an error message. (currently four minutes past the point where it was sent).

#10 Updated by Raymond Hoh almost 7 years ago

Cdev can sometimes be a bit finicky with how WP cron jobs are fired; I just made sure the cron job on cdev started two minutes ago. So far, no new emails have appeared in the debug log.

Did you schedule an email to fire immediately in Boomerang? Or at a certain time?

Update: Just checked the inbox, your email was flagged as spam by GMail.

#11 Updated by Matt Gold almost 7 years ago

I scheduled it two minutes ahead of the time when I wrote it. In a real-life situation, I'd be writing an email at 2:38am and have it sent at 7am ;)

#12 Updated by Matt Gold almost 7 years ago

Update: Just checked the inbox, your email was flagged as spam by GMail.

Interesting / uh-oh. Thoughts?

#13 Updated by Matt Gold almost 7 years ago

the message appears to have come through

#14 Updated by Raymond Hoh almost 7 years ago

I just unspammed the email and ran into one other RBE bug that I just fixed. Now, RBE parsed the Boomerang email successfully!

Regarding why the email was marked as spam, I see two things that might have triggered GMail's spam filter:

1) It could have been the contents of the email - "wat you talkin bout?"
2) It could have been the group permalink - "testy-test-960557098" as it looks spammy

But in both cases, that would be very aggressive spam targeting by GMail!

Perhaps try a more, email-like email? :)

It's something to definitely keep an eye on.

#15 Updated by Matt Gold almost 7 years ago

Hi Ray --

Started a new thread and submitted a RBE with non-spammy content. Unfortunately, it doesn't seem to have come through . . .

#16 Updated by Raymond Hoh almost 7 years ago

Looks like after 1.4.5 was released, Boone forgot to deactivate / reactivate RBE; RBE needs to be reactivated when new code updates are made.

Matt: If you feel comfortable, since you are a super admin, you should be able to deactivate / activate plugins. If you don't feel comfortable, then Boone can handle this when he gets to it.

#17 Updated by Boone Gorges almost 7 years ago

Oops, sorry. I've deactivated and reactivated the plugin.

Aside - why is this necessary, Ray? Weird.

#18 Updated by Raymond Hoh almost 7 years ago

Boone: I'm not too sure myself. It could be something to do with PHP running the codebase from memory and the pseudo-daemon never really finishes exiting the script.

Matt: Which email did you send? I don't see any problems in the log. I also logged in to GMail and noticed that there were six emails by you that were posted between this morning and now. Can you forward me the email in question so I can compare?

#19 Updated by Raymond Hoh almost 7 years ago

Okay, this is resolved!

Matt was testing on cdev and I thought he posted on the production site. Since traffic is needed in order to fire RBE and since cdev isn't frequently trafficked, that's why RBE didn't run until just now.

#20 Updated by Matt Gold almost 7 years ago

ah, okay. Just posted another message but it hasn't come through yet -- presumably for the reason you noted above. Very glad the Boomerang issue is resolved!

Looking at this ticket, we've strayed a bit from the primary issue at hand. Is the failure message issue now resolved?

Thanks, as always, for your great work and your help.

#21 Updated by Raymond Hoh almost 7 years ago

Cool, glad Boomerang works!

Yes, we definitely strayed from the original intent of the issue, but it was due to Boomerang finding a bug in RBE that caused the issue in the first place.

I can address the subject line for failed emails for 1.4.7 as originally intended.

#22 Updated by Matt Gold almost 7 years ago

Great -- thanks so much on all counts, Ray!

#23 Updated by Boone Gorges almost 7 years ago

  • Target version changed from 1.4.7 to 1.4.8

#24 Updated by Boone Gorges over 6 years ago

  • Target version changed from 1.4.8 to 1.4.9

#25 Updated by Boone Gorges over 6 years ago

  • Target version changed from 1.4.9 to 1.4.10

#26 Updated by Boone Gorges over 6 years ago

  • Target version changed from 1.4.10 to 1.4.11

#27 Updated by Boone Gorges over 6 years ago

  • Target version changed from 1.4.11 to 1.4.12

#28 Updated by Boone Gorges over 6 years ago

  • Target version changed from 1.4.12 to 1.4.13

#29 Updated by Boone Gorges over 6 years ago

  • Target version changed from 1.4.13 to 1.4.14

#30 Updated by Boone Gorges over 6 years ago

  • Target version changed from 1.4.14 to 1.4.15

#31 Updated by Boone Gorges over 6 years ago

  • Target version changed from 1.4.15 to 1.4.16

#32 Updated by Boone Gorges over 6 years ago

  • Target version changed from 1.4.16 to 1.4.17

#33 Updated by Boone Gorges over 6 years ago

  • Target version changed from 1.4.17 to 1.4.18

#34 Updated by Boone Gorges over 6 years ago

  • Target version changed from 1.4.18 to 1.4.19

#35 Updated by Boone Gorges over 6 years ago

  • Target version changed from 1.4.19 to 1.4.20

#36 Updated by Boone Gorges over 6 years ago

  • Target version changed from 1.4.20 to 1.4.21

#37 Updated by Boone Gorges over 6 years ago

  • Target version changed from 1.4.21 to 1.4.22

#38 Updated by Boone Gorges over 6 years ago

  • Target version changed from 1.4.22 to 1.4.23

#39 Updated by Boone Gorges over 6 years ago

  • Target version changed from 1.4.23 to 1.4.24

#40 Updated by Boone Gorges over 6 years ago

  • Target version changed from 1.4.24 to 1.4.25

#41 Updated by Boone Gorges over 6 years ago

  • Target version changed from 1.4.25 to 1.4.26

#42 Updated by Boone Gorges about 6 years ago

  • Target version changed from 1.4.26 to 1.4.27

#43 Updated by Boone Gorges about 6 years ago

  • Target version changed from 1.4.27 to 1.4.28

#44 Updated by Boone Gorges about 6 years ago

  • Target version changed from 1.4.28 to 1.4.29

#45 Updated by Boone Gorges about 6 years ago

  • Target version changed from 1.4.29 to 1.4.30

#46 Updated by Boone Gorges about 6 years ago

  • Target version changed from 1.4.30 to 1.4.31

#47 Updated by Micki Kaufman about 6 years ago

Hi Ray: Can you update this issue with the current status or an ETA for completion? We're hoping to get this included in an upcoming minor release. Thanks!

#48 Updated by Raymond Hoh about 6 years ago

Could use some feedback with the wording:

Hi there,

Your reply could not be posted because we could not find the "--- Reply ABOVE THIS LINE to add a comment ---" marker in the body of your email.

In the future, please make sure you reply *above* this line for your comment to be posted on the site.

For reference, the subject line of your reply was "X".

If you have any questions, please let us know.

X usually looks like this - "Re: Ray replied to the topic Test Topic in the forum Test Forum [Site Name]"

Let me know what you think before I make this change.

#49 Updated by Matt Gold about 6 years ago

Looks good, Ray - thanks.

#51 Updated by Raymond Hoh about 6 years ago

  • Status changed from Assigned to Resolved
  • % Done changed from 0 to 100

Added this to a bunch of RBE fixes in commit c01548f.

Also available in: Atom PDF