Bug #21483
closedCV cover/profile image URL generation not compatible with S3-Uploads
0%
Description
It appears that CV cover/profile images are not fully compatible with S3-Uploads. The uploaded images are sent to S3, but the image URLs on the front end don't point to S3. I think this is because of Media\get_profile_image_base_url() and Media\get_cover_image_base_url(), which use home_url() rather than wp_upload_url() and thus aren't filtered by the S3-Uploads plugin.
I thought about making the necessary change myself, but I was worried I'd break something :-D Jeremy, could you please have a look, and also think about whether there are other related interfaces that might be affected (ie default cover images)?
Related issues
Updated by Boone Gorges 3 months ago
- Related to Feature #21383: Offload media using S3-Uploads added
Updated by Boone Gorges about 1 month ago
- Status changed from New to Resolved
I've put the fix in place in https://github.com/cuny-academic-commons/cac/commit/9f127777f40b5fd7385709c715e40653fe57a504
Updated by Jeremy Felt about 1 month ago
Hey Boone - I just missed you on this one, sorry about that.
I've got a fix/cv-s3-uploads branch up that should be a bit more comprehensive:
1. The profile image issue is an easy switch to wp_upload_dir()
2. The cover images were (face palm) being stored very badly with full URLs in the database. I've refactored this so that only the image name is stored and the full URL is built dynamically.
I'm not sure if that's useful in 2.5.x yet or in the reclaim-migration branch, happy to merge it into either or for you to!
Updated by Boone Gorges about 1 month ago
Thanks, Jeremy! This approach looks good. Feel free to roll back what I put in the reclaim-migration branch and merge it there.
Updated by Colin McDonald about 1 month ago
Thanks from me too, Jeremy. If you could update this ticket when the new code is available in the reclaim-migration branch to test, the testing team would like to have a look.
Updated by Boone Gorges about 1 month ago
In the interest of time, I've merged the changes myself.