Project

General

Profile

Actions

Bug #2159

closed

Page redirection after accepting group invite

Added by Matt Gold over 11 years ago. Updated about 11 years ago.

Status:
Resolved
Priority name:
Normal
Assignee:
Dominic Giglio
Category name:
BuddyPress (misc)
Target version:
Start date:
2012-09-30
Due date:
% Done:

0%

Estimated time:
Deployment actions:

Description

Report from a user trying to accept an invite to a private group: "I hit the accept link and was sent to the main CAC site, whether I was logged in or not."

Actions #1

Updated by Matt Gold over 11 years ago

  • Description updated (diff)
Actions #2

Updated by Boone Gorges over 11 years ago

  • Assignee changed from Boone Gorges to Dominic Giglio
  • Target version set to 1.4.7

Dom, could you try to reproduce please?

Actions #3

Updated by Dominic Giglio over 11 years ago

  • Target version changed from 1.4.7 to 1.4.8
Actions #4

Updated by Dominic Giglio over 11 years ago

  • Target version changed from 1.4.8 to 1.4.9
Actions #5

Updated by Dominic Giglio over 11 years ago

Boone,

I've been trying to reproduce both this and the issue in #2176 (updating that issue next). I've tried inviting a different user to each of the three group types - Public, Private and Hidden. All three worked just fine in my local env. I also wanted to bring up that in the user report in the description they say:

whether I was logged in or not

Which really doesn't make sense. If they WEREN'T logged in, they wouldn't be able to see their invites.

Also, I'm curious if this could be related to the login issues we have open in other tickets? The no cookie problems. Let me know what you think.

Actions #6

Updated by Boone Gorges over 11 years ago

  • Status changed from Assigned to Rejected

If they WEREN'T logged in, they wouldn't be able to see their invites.

Right. I assume that "the accept link" means the link in the notification email, which you would see whether or not you're logged in in the browser.

Also, I'm curious if this could be related to the login issues we have open in other tickets? The no cookie problems.

This is my guess. Since you can't reproduce the issue, and we've resolved the cookie stuff for the time being #228, I'm going to reject this ticket. If the problem arises again, let's revisit.

Actions #7

Updated by Dominic Giglio over 11 years ago

Sounds like a plan.

Actions #8

Updated by Matt Gold over 11 years ago

Hi All,

I've added the original reporter, Jen Gieseking, to this ticket. Jen, can I ask you to read through the reporting from the Commons dev team above and let us know what you think and whether you've experienced this again?

Thanks,

Matt

Actions #9

Updated by Matt Gold over 11 years ago

More info from Jen, insofar as I understand things:

1. User received an invitation to create an account on the Commons and to a group through invite by email
2. When user clicks on the linked phrase "To accept this invitation, please visit https://commons.gc.cuny.edu/register/accept-invitation/JGieseking%40gc.cuny.edu" after already having created an account on the site, she is redirected to the homepage of the Commons
3. By contrast, when the user clicks on an invitation to a group that she has already accepted, she is directed to the group homepage.

A suggested fix:
-- Instead of redirecting to the home page in #2 above, it would be better for the user to receive a "You have already accepted this invitation" error message. If we can implement that, we can create a new ticket for the creation of that error message. I'd mark it with a low/trivial priority. Thoughts?

Actions #10

Updated by Dominic Giglio over 11 years ago

Boone,

Would this need to be a patch to BuddyPress core? I'm thinking the code responsible for accepting and verifying both invites and registrations is pretty central to how BP works, and therefore isn't in a plugin.

If you could point me to the area that handles these verifications I'll see what I can come up with.

Actions #11

Updated by Matt Gold over 11 years ago

If the above info is correct, this has to do with Invite Anyone http://wordpress.org/extend/plugins/invite-anyone/

Actions #12

Updated by Boone Gorges over 11 years ago

If the above info is correct, this has to do with Invite Anyone http://wordpress.org/extend/plugins/invite-anyone/

Correct. This is not a group invite at all, but an invitation created by Invite Anyone. If an improvement is to be made, it's to that plugin.

Actions #13

Updated by Dominic Giglio over 11 years ago

  • Status changed from Rejected to Assigned
  • Target version changed from 1.4.9 to 1.4.10

Thanks Boone.

I'll look through the plugin and see if I can find a spot to enable the features you described Matt.

Re-openning and moving to 1.4.10 for now.

Actions #14

Updated by Dominic Giglio over 11 years ago

  • Target version changed from 1.4.10 to 1.4.11
Actions #15

Updated by Dominic Giglio over 11 years ago

  • Target version changed from 1.4.11 to 1.4.12
Actions #16

Updated by Dominic Giglio over 11 years ago

  • Target version changed from 1.4.12 to 1.4.13
Actions #17

Updated by Boone Gorges over 11 years ago

  • Target version changed from 1.4.13 to 1.4.14
Actions #18

Updated by Boone Gorges over 11 years ago

  • Target version changed from 1.4.14 to 1.4.15
Actions #19

Updated by Boone Gorges over 11 years ago

  • Target version changed from 1.4.15 to 1.4.16
Actions #20

Updated by Boone Gorges over 11 years ago

  • Target version changed from 1.4.16 to 1.4.17
Actions #21

Updated by Boone Gorges about 11 years ago

  • Target version changed from 1.4.17 to 1.4.18
Actions #22

Updated by Boone Gorges about 11 years ago

  • Target version changed from 1.4.18 to 1.4.19
Actions #23

Updated by Boone Gorges about 11 years ago

  • Target version changed from 1.4.19 to 1.4.20
Actions #24

Updated by Boone Gorges about 11 years ago

  • Target version changed from 1.4.20 to 1.4.21
Actions #25

Updated by Boone Gorges about 11 years ago

  • Target version changed from 1.4.21 to 1.4.22
Actions #26

Updated by Boone Gorges about 11 years ago

  • Target version changed from 1.4.22 to 1.4.23
Actions #27

Updated by Boone Gorges about 11 years ago

  • Target version changed from 1.4.23 to 1.4.24
Actions #28

Updated by Boone Gorges about 11 years ago

This ended up being more complicated than I'd expected, as it's actually a BuddyPress issue that I managed to solve using Invite Anyone.

IA - https://github.com/boonebgorges/invite-anyone/commit/89d215045856bcf47f1a025de389150929dd17c0
CAC - https://github.com/castiron/cac/commit/c4929fc9e8a44a8864554e96b644d0b7226fc05f

Actions #29

Updated by Boone Gorges about 11 years ago

  • Status changed from Assigned to Resolved
Actions #30

Updated by Dominic Giglio about 11 years ago

Sweet! This is one of two or three issues that I haven't been able to get my head back into yet. Thanks for closing it out for me.

Actions

Also available in: Atom PDF