Project

General

Profile

Bug #2188

Line Spacing/Breaks on BP Docs

Added by Matt Gold almost 9 years ago. Updated almost 9 years ago.

Status:
Resolved
Priority name:
Normal
Assignee:
Category name:
BuddyPress (misc)
Target version:
Start date:
2012-10-13
Due date:
% Done:

0%

Estimated time:

Description

I find that it's very difficult to create line breaks on BP docs -- if one is creating unordered lists, line/paragraph breaks added to the visual editor don't translate to the rendered doc (please see attached screenshots for three views -- doc in visual editor, doc in html editor, doc in rendered form).

My understanding is that we're just using the default WP posting interface, so there may not be anything we can do that wouldn't be part of a larger overhaul of that interface. But I wanted to raise it here because it's a usability issue for BP Docs.

bp-doc-visual-editor.png (52.4 KB) bp-doc-visual-editor.png Matt Gold, 2012-10-13 10:50 AM
bp-doc-html-editor.png (72.1 KB) bp-doc-html-editor.png Matt Gold, 2012-10-13 10:50 AM
bp-doc-rendered-doc.png (40.8 KB) bp-doc-rendered-doc.png Matt Gold, 2012-10-13 10:50 AM

History

#1 Updated by Chris Stein almost 9 years ago

Matt, my first thought on this is that it is a CSS issue and nothing to do with the editor. I'd have to see the doc live to double check. Problem with how lists are formatted are common (IMHO) on WP themes. I think most of it has to do with styling for navigation (which are usually unordered lists) not being restricted to the nav and where theme designers use a CSS reset that strips margin and padding and forget to add it back in for lists.

If you put that doc in a group where I can see it I'll take a look. On a related note we should remember to see how the infinity theme holds up to lists and nested lists.

#2 Updated by Matt Gold almost 9 years ago

Hi Chris,

Okay - just sent you an invite to a hidden group where I've reposted the doc. Thanks.

#3 Updated by Chris Stein almost 9 years ago

I took a quick look and I do think it's a CSS issue. Maybe we can talk more today about options for how we might want to make it look.

#4 Updated by Boone Gorges almost 9 years ago

  • Assignee changed from Boone Gorges to Chris Stein
  • Target version set to 1.4.9

#5 Updated by Chris Stein almost 9 years ago

Right now lists don't have any styling outside of everything being removed by the reset css and then a left margin added in. It wouldn't be hard to add in some more default styling for them.

Matt, do you have an idea of how you'd like the spacing to be?

Boone, which CSS file would you like me to modify?

For now, given the other time constraints we're under I'd like to do a quick fix on this, but in the future we should take a longer look at how the BP docs are styled and also make sure the same styles are applied to the edit and view states. Or at least mostly similar, perhaps some differences are needed to help differentiate the two. That may also be part of an overall Commons Style Guide.

#6 Updated by Boone Gorges almost 9 years ago

Chris, why don't you just tell me the styles that you want to add, and I'll go ahead and put them in the codebase. (You can just paste them here in this ticket.)

#7 Updated by Dominic Giglio almost 9 years ago

Boone,

Online 282 of bp-docs.css add:

margin: 15px 0 25px 15px;

That should take care of the ul styling for now.

Also available in: Atom PDF