CUNY Academic Commons

Boone,

Sorry I've been silent for so long, I'm swamped with midterms. I can see where Matt updated the upload settings and added "sav" to the list. I've looked all over the dashboard (both Network and Commons) but I'm not seeing any other settings related to Files in Groups. Is this a feature provided natively by BP or are we running a plugin to provide "Files" group support?

Just FYI, I think that the member is using blogs rather than groups.

. . . . but I thought we could do both just to be safe.

Boone, I remember that a while ago, when we wanted to allow people with certain email domains to register, you had to create a second field within the dashboard to do it. Don't know whether we're running into a similar problem here, where the standard network admin protocol isn't working for some reason . ..

Matt,

What is the "Commons Upload to Library Program?"

I think the member was trying to describe the upload to media library through the dashboard of a blog.

It appears we may need to add some custom code to the next release to make this work:

http://www.paulund.co.uk/change-wordpress-upload-mime-types

Can someone send me an actual .sav file so that I can test properly? (Mime-type spoofing can cause its own problems.)

Boone,

I've verified in my local dev that your addition from comment 13 does indeed enable the uploading of sav files through the WP media uploader.

However, it does not carry over to group docs, I get an error when I try to upload the attached sav file. So I started looking through the buddypress-group-documents plugin and found two places that define and check the allowed file types:

On line 175 of the main plugin file (index.php), in bp_group_documents_check_installed() the default file types are added to the DB.
On line 525 of index.php, bp_group_documents_check_ext() validates the extension of the uploaded file.

Admin.php also checks and updates the DB with new allowed types. But the problem I'm having locally is that I CANNOT find the BP Group Docs admin page anywhere. I've looked all over my local env and on the production site (both network and non-network). Where the heck are these admin settings rendered?! :-)

Where the heck are these admin settings rendered?! :-)

Heh, they're not. Their menu is not hooked correctly. The whole plugin is pretty old and shoddy, so we can't exactly fix it the right way, but what we can do is change the 'admin_menu' hook to 'network_admin_menu', around line 184 of buddypress-group-documents/index.php (and wherever else in the plugin 'admin_menu' is used). That should at least make it so that the "Group Files" menu appears under BuddyPress in Network Admin.

OK, I get to work on that now.

Just so I know, does this plugin only exist inside our repo? The link in the header comments to the WP plugin repo says the plugin can't be found. I'm really just wondering if there is a separate repo somewhere that I should be keeping up-to-date with the changes I'm making in our repo.

The plugin was abandoned and removed from the repo. So no, don't worry about upstream contributions in this case.

Understood. Already got the admin page working under BP network settings. Getting a weird "You do not have sufficient permissions to access this page." error when saving new settings, but I'll figure it out.

Boone,

I have a feeling that this update might cause a lot of extra work for me, but I'm wondering if we should put this issue on hold and attach it to a new issue where we can discuss rewriting the buddypress-group-documents plugin? It seems to me that the functionality it provides is pretty important in the grand scheme of our site. If it's abandoned and in need of updating, maybe I should start working on it?

It could be refactored out into a buddypress-files plugin similar to buddypress-docs (and by similar I mean a similar naming convention, not similar functionality). The current name itself is kinda confusing. I'm also wondering if there's some naming conflicts between bp-docs and group-docs due to the use of the word "Documents" in both plugins? If you think this is a little too much for me to take on right now let me know. So far Featured Content is the biggest plugin job I've worked on. Looking through the files for group-docs I can see that it would be no small job to produce a new version. But it would be really great practice for me to get better with the intricacies of actions and filters. :-)

Sorry - missed this update when you switched it back to you.

If you can fix it quickly, I'm all about that. I look forward to discussing a rewrite with you and Ray after CBox release.

I know you're busy with CBox and tonight's release, but I'm just curious about one thing. The change you made in admin.php:

<form action="<?php echo network_admin_url() . '/admin.php?page=bp-group-documents-settings' ?>" 

Do you think this is why I was getting the "You do not have sufficient permissions to access this page." error? All I changed in my local env was the references to 'admin_menu'. So the settings pages showed up but I couldn't save any new settings. I really just wanna try and remember this if (when) I see that error again.

Do you think this is why I was getting the "You do not have sufficient permissions to access this page." error

Yes. The form action was previously pointing to a WP dashboard page that did not exist, and the "You do not have sufficient..." error is WP's generic error message for this kind of situation.

cool, thanks.

Just going through tickets that piled up while I was offline. Thanks to you both for your work on this.