Project

General

Profile

Bug #2240

Update Luna theme

Added by Matt Gold over 9 years ago. Updated over 9 years ago.

Status:
Resolved
Priority name:
Normal
Category name:
WordPress (misc)
Target version:
Start date:
2012-11-11
Due date:
% Done:

0%

Estimated time:

Description

Hi Dom,

I've included an updated file for the Luna theme luna/js/fadeslide/fadeslide.js that makes a very minor change in line 11:

from

}).cycle('pause');

to

}).cycle();

It is my hope/belief that this will cause the slider in the Luna theme to start on pageload and cycle through the slides, rather than remaining paused on the first slide. If you have a moment, can you confirm this fix and make this part of today's upload? It's in connection with a high-profile site (http://chasefrobinson.commons.gc.cuny.edu/), so I'd love to have this fixed today. Thanks.

fadeslide.js (338 Bytes) fadeslide.js Matt Gold, 2012-11-11 09:28 AM

Related issues

Related to CUNY Academic Commons - Feature #2242: Update Luna Theme to v1.9Resolved2012-11-11

Related to CUNY Academic Commons - Feature #2243: Setup chasefrobinson Theme as a Luna Child Theme.Resolved2012-11-11

History

#1 Updated by Dominic Giglio over 9 years ago

Matt,

Because of the email you sent asking me to take on a kind of "advisory or support" role regarding this site, I took a little extra time and completely recreated this site in my local env. I should now be setup to answer (hopefully) any questions you or Erin may have.

I've verified that the edits you requested to the fadeslide.js file do indeed cause the slider to begin on initial page load. I took it one step further after familiarizing myself with the jQuery Cycle plugin that's being used and changed the js to look like this:

    $j(".slides").cycle({
        pause: 1,
        prev: '.prev',
        next: '.next'
    });

The second call to .cycle() was unnecessary and "fade" is the default transition, so I've removed them both. I've pushed those changes to the repo so they will be included in 1.4.10 tonight.

Commit: https://github.com/castiron/cac/commit/734e07aa96d127fa23a120395e9c9626e4985777

One last thing, there was an update to Luna on Nov 5th. http://themeforest.net/item/luna-responsive-wordpress-theme/2395168

This is currently not setup as a child theme so updating will need to be handled with care to ensure no files are overwritten accidentally. Let me know how you'd like to proceed with the update, if at all, maybe even in a new ticket?

I believe we can mark this as resolved, please do so if you agree.

#2 Updated by Matt Gold over 9 years ago

  • Status changed from Assigned to Resolved

Fantastic -- thanks so much on all counts, Dom. I've sent you what I think is the new version of the theme via email. Can you do two things for me if possible?

1. Create a new ticket for the Luna theme upload and use the files I sent by email if I correctly sent along the new version?

2. Create a child theme for the Provost's site if you think that's the best way forward. It seems to me that it is. Please create a ticket for that, too.

Many thanks and most of all thanks for taking on an advisory role with Erin. Much appreciated.

#3 Updated by Dominic Giglio over 9 years ago

Yes, the email you sent does contain 1.9.

I'm gonna start working this into a child theme setup so we can more confidently update as new versions become available. I'll open both of the tickets you requested as I move through the process. I'll open (and close) them in 1.4.10 if I can. If I feel that rushing this process is going to adversely affect the site then I think we should consider punting them to 1.4.11. Being correct is more important than being fast.

#4 Updated by Matt Gold over 9 years ago

Agreed. thanks on all counts, Dom.

Also available in: Atom PDF