Project

General

Profile

Feature #2243

Setup chasefrobinson Theme as a Luna Child Theme.

Added by Dominic Giglio over 9 years ago. Updated over 9 years ago.

Status:
Resolved
Priority name:
Normal
Category name:
WordPress (misc)
Target version:
Start date:
2012-11-11
Due date:
% Done:

0%

Estimated time:

Description

The Provost site: http://chasefrobinson.commons.gc.cuny.edu/ is currently installed as a customized version of the Luna theme. To improve development moving forward we should implement the theme as a child of Luna. This will allow us to more easily update the core Luna parent without having to worry about breaking custom features.


Related issues

Related to CUNY Academic Commons - Feature #2242: Update Luna Theme to v1.9Resolved2012-11-11

Related to CUNY Academic Commons - Bug #2240: Update Luna themeResolved2012-11-11

History

#1 Updated by Matt Gold over 9 years ago

Thanks, Dom. Added Erin as a watcher on this.

#2 Updated by Dominic Giglio over 9 years ago

Thanks, I shoulda remembered to add Erin. :-)

I've added the new luna-cfr child theme to our repo, so it will be included in the 1.4.10 release. I started our customizations off with a functions.php file in our child that deregisters the parent's version of fadeslide.js and registers the customized version that forces the slider to start on page load. This was actually what started me off thinking about a parent vs child setup. I figured if we were going to be making more edits like this we needed to move to a child sooner rather than later. The update to 1.9 would have overridden our custom js.

I've also added a reminder to ACTION_REQUIRED to enable this child for chasefrobinson.

I think we'll be able to close this issue out tonight just like #2242. As soon as I verify the site is behaving appropriately.

Commit: https://github.com/castiron/cac/commit/447477a3ee5bf3e51be0df456627389d77ad60ed

#3 Updated by Matt Gold over 9 years ago

Fantastic. Thanks, Dom! Can I ask you to email all child theme files you've created to Erin so that she can study what you've done? Many thanks.

#4 Updated by Matt Gold over 9 years ago

No rush on that emailing, btw. At your convenience.

#5 Updated by Boone Gorges over 9 years ago

Dom, I've enabled (but not activated) the theme on the Provost blog.

#6 Updated by Dominic Giglio over 9 years ago

  • Status changed from Assigned to Resolved

Thanks Boone.

I've activated and verified that we are GODD TO GO!! Child theme operating as expected and slider begins on initial page load.

The only thing I had to update was the Primary Menu. But I knew I was gonna have to do that.

Closing issue.

#7 Updated by Matt Gold over 9 years ago

Awesome work, Dom! Many thanks.

Also available in: Atom PDF