Feature #2248
closedCreate Profile link to academia.edu profile
0%
Description
From a user request:
I assume that in addition to creating the actual profile field, we'll also have to incorporate an icon to keep it in line with our other social media links.
Related issues
Updated by Dominic Giglio over 11 years ago
Boone,
I think I've found the code responsible for this in the bp-social-media-profiles plugin. I'm not sure if this plugin exists outside of our repo, but if you want to reassign this to me I think I can copy some of the existing code to create an additional profile field for academia.edu. It looks like I could simply duplicate the Facebook Profile link code.
Feel free to kick this over to me, if it's as simple as it looks I might be able to get it in to 1.4.x.
Updated by Boone Gorges over 11 years ago
- Assignee changed from Boone Gorges to Dominic Giglio
Dom - Yes, bp-social-media-profiles is the plugin responsible for turning those fields into icons. If you'd like to have a go at adding academia.edu support, that'd be great. Here's the repo: https://github.com/boonebgorges/bp-social-media-profiles Fork and send a pull request when you've got something :)
Updated by Dominic Giglio over 11 years ago
Added the requested pull request:
https://github.com/boonebgorges/bp-social-media-profiles/pull/4
Updated by Boone Gorges over 11 years ago
I've merged the pull request. Dom, please put the merged version into the CAC codebase, and make sure it works as expected on your local install before committing it. Thanks.
Updated by Dominic Giglio over 11 years ago
- Status changed from Assigned to Resolved
- Target version changed from 1.4.12 to 1.4.11
I've updated the repo with the latest changes to bp-social-media-profiles to support academia.edu profile links (after testing in my local env).
Boone, at some point we need to revisit this plugin on Github. Some changes to bp-social-media-profiles.php were preventing the icons from showing up on a user's profile page. I basically updated our repo with all the new files except that one. The master branch appears to have had some functions removed?
There's way too much going on right now to worry about this, but we should revisit in the future to make sure the plugin works the way it's supposed to.
I've also added a note to ACTION_REQUIRED to let the original reporter know that this functionality has been added to the commons.
Commit: https://github.com/castiron/cac/commit/36e279cc014a96727b23a74e47c971361e127f64
Updated by Boone Gorges over 11 years ago
This looks good on the updated site.
I don't have access to contact the original reporter. Matt, perhaps you can do so?
Updated by Matt Gold over 11 years ago
Yes, I'll get in touch with the originator. Thanks for your work on this, Dom and Boone.