Project

General

Profile

Actions
Copy link

Bug #22966

closed

Site ID pictures not appearing in Commons site directory

Added by Laurie Hurson 24 days ago. Updated 9 days ago.

Status:
Resolved
Priority name:
Normal
Assignee:
-
Category name:
S3 Uploads
Target version:
2.5.11
Start date:
2025-06-23
Due date:
% Done:

0%

Estimated time:
Deployment actions:

Description

Hi All,

On a call earlier we found that some site ID images are not appearing in the site directory - instead replaced by the words "Site icon for [site title]."

I believe images not appearing should be pulling from the Site Identity "icon", which users input in the customize area of the site. I am wondering if maybe the sites where this is not working are possibly private sites, and something is wrong with the image pulls from the server?

Let me know what you think, thanks!

Files

Download all files
Screenshot 2025-06-23 at 2.51.08 PM.png (602 KB) Screenshot 2025-06-23 at 2.51.08 PM.png Laurie Hurson, 2025-06-23 02:54 PM
Screenshot 2025-07-02 at 12.32.32 PM.png (610 KB) Screenshot 2025-07-02 at 12.32.32 PM.png Laurie Hurson, 2025-07-02 12:33 PM
Screenshot 2025-07-02 at 12.33.29 PM.png (751 KB) Screenshot 2025-07-02 at 12.33.29 PM.png Laurie Hurson, 2025-07-02 12:33 PM
Actions
Copy link
 #1

Updated by Raymond Hoh 24 days ago

  • Category name set to S3 Uploads
  • Status changed from New to Resolved
  • Target version set to 2.5.11

I am wondering if maybe the sites where this is not working are possibly private sites, and something is wrong with the image pulls from the server?

This is exactly what is happening. I've just added a fix so the S3 signed parameters are added to the site icon image URL to make private site icons viewable on the Site Directory page: https://github.com/cuny-academic-commons/cac/commit/9e2c48270e84c1d91c9cddf559788bbbd37906a5. This is deployed to production.

Actions
Copy link
 #2

Updated by Laurie Hurson 23 days ago

Great-- thanks Ray!

Actions
Copy link
 #4

Updated by Raymond Hoh 15 days ago

Thanks for the report, Laurie.

I tried to limit the calls to look up the site's privacy settings for performance reasons, but that doesn't work all the time, so I'm fetching the site's privacy settings at all times now in https://github.com/cuny-academic-commons/cac/commit/e1aa8b709f144d7599f737f67a0ec50e0f4fb76d. This is deployed to production.

Boone, to make the private site icon call more optimal, we might need to start mirroring the 'blog_public' option to BP blogmeta, then we will not need to do a switch_to_blog() call for every site in the Sites Directory. What do you think?

Actions
Copy link
 #5

Updated by Boone Gorges 9 days ago

Boone, to make the private site icon call more optimal, we might need to start mirroring the 'blog_public' option to BP blogmeta, then we will not need to do a switch_to_blog() call for every site in the Sites Directory. What do you think?

I think it's a fine idea - kinda surprised we don't already do this.

Actions
Copy link

Also available in: Atom PDF