Project

General

Profile

Actions

Bug #23237

closed

Unsubscribe link in Commons email notifications error

Added by Matt Gold 5 months ago. Updated 5 months ago.

Status:
Resolved
Priority name:
Low
Assignee:
Category name:
Email Notifications
Target version:
Start date:
2025-08-25
Due date:
% Done:

0%

Estimated time:
Deployment actions:

Description

After receiving a group membership request message from a group that I run on the CAC, I mistakenly clicked "unsubscribe" instead of "Go here to manage this and other requests"

I was logged out from the CAC at the time. I noticed that the unsubscribe link brought me to my CV page, which I think is wrong.

The "manage this" link brought me first to a log-in page, and then to my intended location -- the group membership management page.

It seems to me that if someone had actually wanted to unsubscribe and was not logged in, the "unsubscribe" link should have brought them first to a log-in page, and then to a settings page where they could unsubscribe from the group.

Though, actually, for this particular message -- the group membership approval message -- it's unclear what "unsubscribe" would mean, as I'm not sure that it's possible for group admins not to get messages when people make membership requests

Anyway, I suggest that we review the "unsubscribe" links/functionality in these and other email notification messages.

Actions #1

Updated by Raymond Hoh 5 months ago

  • Status changed from Assigned to Staged for Production Release
  • Target version set to 2.5.14

Thanks for the report, Matt.

There are two issues when you click on a BuddyPress email unsubscribe link:

1. Clicking the unsubscribe link redirects you to your BP profile URL. However, we modified the default content on the BP profile URL to display the user's CV.
2. If you are logged out and when you click on the unsubscribe link, you will arrive on your BP profile URL. A message should also be displayed saying that you've been unsubscribed from further group membership request emails. However, as of BuddyPress v14.3.4, this message is only displayed for logged-in users. Logged-out users will not see this message.

For 1, I've changed the link to point to your Commons Profile link (/members/me/activity/) instead. For 2, I've also altered the redirect URL so we are able to show template message notices to logged-out users. See https://github.com/cuny-academic-commons/cac/commit/906a2e5bdff0b93f0e91e5cf6d32b1ecca9edb22 .

This will be a part of tomorrow's maintenance release. I've also posted a ticket about this bug to BuddyPress Trac: https://buddypress.trac.wordpress.org/ticket/9301.

Actions #2

Updated by Matt Gold 5 months ago

Thanks, Ray!

2. If you are logged out and when you click on the unsubscribe link, you will arrive on your BP profile URL. A message should also be displayed saying that you've been unsubscribed from further group membership request emails. However, as of BuddyPress v14.3.4, this message is only displayed for logged-in users. Logged-out users will not see this message.

Does clicking on the link mean that I am now unsubscribed from the group, even though I didn't see the message, since I wasn't logged in?

Actions #3

Updated by Raymond Hoh 5 months ago

You're not unsubscribed from the group, but you will no longer receive all group membership request emails.

To re-enable these emails, go to https://commons.gc.cuny.edu/members/me/settings/notifications and toggle the "A member requests to join a private group for which you are an admin" option and save.

Actions #4

Updated by Boone Gorges 5 months ago

Matt's alluded several times to the "even though I'm not logged in" part of the Unsubscribe link. I just wanted to chime in and say that this aspect of the feature arises out of GDPR, CAN-SPAM, and similar legislation, which require the presence of an unsubscribe mechanism in emails, and which urge that it should be relatively easy to unsubscribe (thus the no-login part).

Actions #5

Updated by Boone Gorges 5 months ago

  • Status changed from Staged for Production Release to Resolved
Actions #6

Updated by Matt Gold 5 months ago

Raymond Hoh wrote in #note-3:

You're not unsubscribed from the group, but you will no longer receive all group membership request emails.

To re-enable these emails, go to https://commons.gc.cuny.edu/members/me/settings/notifications and toggle the "A member requests to join a private group for which you are an admin" option and save.

Wow. I'm not sure that unsubscribing from ALL group membership request emails is the expected behavior. Is there a way to do it on a group-by-group basis?

Even taking Boone's GDPR point above, I want to note a few things:

  • it's easy to mistakenly click on the unsubscribe link, as I did here
  • doing so makes a pretty dramatic change in site functionality with no messaging to the user about that change
  • people often forward messages, and someone else can click on the unsubscribe link, thereby making an undesired change for the user who forwarded the message.

I see a few ways to address some of this, and perhaps Boone and Ray see others. But here are some possibilities:

1. require a confirmation before the change is made (though this would go against Boone's point that it should be easy/quick)
2. notify the user that the change has been made. (that would perhaps create another unwanted email, but it would serve as confirmation for a user who desired the change and would serve as an alert for a user who didn't realize the change happened)
3. we should document this behavior, whichever way we go

Please let me know what you think. Adding Sara and Colin to the ticket, too

Actions #7

Updated by Raymond Hoh 5 months ago

Wow. I'm not sure that unsubscribing from ALL group membership request emails is the expected behavior.

That is the current behavior in BuddyPress.

Is there a way to do it on a group-by-group basis?

Currently no, we cannot do the group membership request unsubscribe on a group-by-group basis at this time without further custom development as this would require additional UI screens and options that would need to be added to the frontend -- both in the group's options and when you click on the Unsubscribe link from the email.

1. require a confirmation before the change is made (though this would go against Boone's point that it should be easy/quick)

We should analyze some unsubscribe email workflows that others have done. From other unsubscribe workflows I've personally experienced, there is some form of confirmation step required. Whether that be a simple submit button or a page with various checkboxes of the emails you can unsubscribe from.

2. notify the user that the change has been made. (that would perhaps create another unwanted email, but it would serve as confirmation for a user who desired the change and would serve as an alert for a user who didn't realize the change happened)

This does occur as a notice on the page after clicking on the Unsubscribe link as of today's maintenance release. The message that gets displayed is the following:

You will no longer receive emails when someone requests to be a member of your group. [You can change this or any other email notification preferences in your email settings].

"You can change this or any other email notification preferences in your email settings" is linked to your email notifications settings page.

Actions #8

Updated by Matt Gold 5 months ago

Thank you, Ray!

We should analyze some unsubscribe email workflows that others have done. From other unsubscribe workflows I've personally experienced, there is some form of confirmation step required. Whether that be a simple submit button or a page with various checkboxes of the emails you can unsubscribe from.

Agreed.

This does occur as a notice on the page after clicking on the Unsubscribe link as of today's maintenance release. The message that gets displayed is the following:

You will no longer receive emails when someone requests to be a member of your group. [You can change this or any other email notification preferences in your email settings].

"You can change this or any other email notification preferences in your email settings" is linked to your email notifications settings page.

Thank you! One small recommended change: "You will no longer receive emails when someone requests to be a member of any of your groups." (to reflect the actual change being made not just to the group in question, but to all groups

Actions

Also available in: Atom PDF