Feature #2360
closedConfirmation before File Deletion
0%
Description
Right now, if you delete a file in a group, you just hit "delete" and the file gets removed. I think we should require a confirmation of file deletions to ensure that files aren't deleted accidentally. Perhaps a pop-up saying something like "Confirm deletion of [filename]" with an "OK" button. Or whatever implementation sounds better to you and Chris.
Updated by Chris Stein over 11 years ago
Using a popup to confirm deletion is fine with me.
Another possible style is doing the deletion first and then adding a popup that says "File xxx was deleted. Undo" where undo is a link. Google uses this now for example when you delete a file in google drive. However deleting a file is a more deliberate process there (you have to check a box and then click the trash icon) so mistakes are less likely. We have the delete link right next to the edit link so it's easier to make a mistake so unless we're going to change the interface, the first option, confirmation before deletion, seems to make the most sense to me.
Updated by Matt Gold over 11 years ago
Thanks, Chris. I remain agnostic on this. If there is one solution that's easier to implement than another, let's go with it.
Updated by Boone Gorges over 11 years ago
- Status changed from Assigned to Resolved
I went for the simple confirm box. Fixed in https://github.com/castiron/cac/commit/fb787df521e340aeaa7980a404fbc5752f453894