Project

General

Profile

Actions

Bug #2479

closed

Double posting, double notification of message posted via RBE

Added by Matt Gold over 9 years ago. Updated over 9 years ago.

Status:
Resolved
Priority name:
Urgent
Assignee:
Category name:
BuddyPress (misc)
Target version:
Start date:
2013-02-25
Due date:
% Done:

50%

Estimated time:

Description

Just received a double notification of a message I posted via RBE to a group. Looks like the message posted twice, as well. Saw something similar when another group member posted earlier today. Please see the attached screenshots. This is for the following group:


Files

Actions #1

Updated by Boone Gorges over 9 years ago

  • Assignee changed from Boone Gorges to Raymond Hoh
  • Priority name changed from Normal to High
  • Target version set to 1.4.20

Ray, could you have a look please? Thanks.

Actions #2

Updated by Raymond Hoh over 9 years ago

Hi,

Can an admin deactivate RBE from the main CAC site and then reactivate it?

It appears there were problems connecting to GMail yesterday and there might have been a race condition where RBE tried to connect twice after failure.

Actions #3

Updated by Boone Gorges over 9 years ago

No problem, Ray - I just toggled it.

Actions #4

Updated by Matt Gold over 9 years ago

  • Priority name changed from High to Urgent

Hi All --

Just saw another instance of this here - http://commons.gc.cuny.edu/groups/digital-dissertations/forum/topic/preservation-questions/#post-13006

Upgrading the priority on this, though, truly, I think it falls somewhere between "high" and "urgent"

Actions #5

Updated by Raymond Hoh over 9 years ago

I need to do a better job at detecting IMAP connections. Since this is a pretty hard issue to debug and test for, I might not be able to address this for 1.4.20.

Boone: I'm thinking of ditching WP cron and using a transient marker instead. I have an idea of how all this may work in my head, but not sure if this will work as I implement it ;)

A temporary fix is checking if the forum reply already exists in the database. BP 1.6 introduced this functionality, but RBE bypasses this as the reply check is only used on frontend posts. This can definitely be done for 1.4.20, but it doesn't address the underlying issue.

Actions #6

Updated by Boone Gorges over 9 years ago

Boone: I'm thinking of ditching WP cron and using a transient marker instead.

That's OK by me. Here's a super-simple version I posted recently: https://gist.github.com/boonebgorges/4714650#file-gistfile1-php (not using transients, but you get the idea) FWIW, this is basically how wp-cron works, except wp-cron is standardized. That said, wp-cron has weird limits on how often you can run an event - I think it's once every 10 minutes. Is that part of the problem with the IMAP stuff?

A temporary fix is checking if the forum reply already exists in the database.

I think that a good feature for RBE would be general dupe detection. Something like:
- Require an abstract method BP_Reply_By_Email_Extension::detect_existing_item().
- Check that ! $extension->detect_existing_item() before $extension->post_by_email()

I know you're not currently using your Extension class for BP-native content types, but the same principle could apply there too. We're only talking about maybe 4 or 5 different content types, and I'm pretty sure there's enough information between the email (timestamp, user name, etc) and the database item to reliably detect dupes in each case.

I know this isn't a trivial thing to implement, but it seems like it would be a good failsafe, and maybe easier to address in the long run than difficult-to-test IMAP issues.

What do you think?

Actions #7

Updated by Boone Gorges over 9 years ago

  • Target version changed from 1.4.20 to 1.4.21
Actions #8

Updated by Raymond Hoh over 9 years ago

  • % Done changed from 0 to 50

I decided to add a stop-gap before I go and overhaul the current WP-cron connection method.

In commit 12761b2, I've added a locking mechanism to RBE.

According to the RBE logs, on occasion, RBE would attempt to connect twice under a minute. This would cause the double posts encountered in this ticket.

The commit sets a transient before connecting to the IMAP server, which expires after 60 seconds. So if a second attempt to connect is made within 60 seconds, that attempt would be stopped.

I think 60 seconds is a long-enough time limit to connect to GMail and should hopefully stop these double connection instances.


I'll also add the duplicate reply exists check in my next commit to CAC.

I think that a good feature for RBE would be general dupe detection. Something like:
- Require an abstract method BP_Reply_By_Email_Extension::detect_existing_item().
- Check that ! $extension->detect_existing_item() before $extension->post_by_email()

Good idea, Boone. Will look into it.

Actions #9

Updated by Boone Gorges over 9 years ago

Awesome - thanks, Ray!

Actions #11

Updated by Boone Gorges over 9 years ago

  • Status changed from Assigned to Resolved

Ray - because it sounds like your stopgap is probably going to resolve this issue for now, and I want to clear the milestone, I'm going to mark this one resolved. If you decide to go forward with the dupe check, we can open a separate ticket for the enhancement (or just roll it in the next time we upgrade RBE).

Actions #12

Updated by Raymond Hoh over 9 years ago

I'm fine with that, Boone.

I've noticed that the RBE log is getting rather large (it's around 8MB right now). We might want to archive the current log and start fresh.

Actions #13

Updated by Boone Gorges over 9 years ago

Good idea, Ray. I've archived it to rbe.log.1 and wiped the content of rbe.log.

Actions #14

Updated by Matt Gold over 9 years ago

Hi All --

Caught what I think might be another instance of this in the CUNY IRT group. Please see attached screenshots and let me know what you think. Thanks.

Actions #15

Updated by Raymond Hoh over 9 years ago

Hi Matt,

I took a look at the RBE log and checked GMail.

Before the double post occurred, RBE got stuck. When RBE tried to reboot itself, RBE somehow ended up connecting to GMail twice at close to the same time, which led to both connections parsing the same email message and thus, the double post.

This looks to be a fringe case, however let me know if this happens again.

I still haven't added the duplicate forum post check that was mentioned earlier in this thread, but I'll do that tomorrow for bbPress 1 and that should alleviate the problem for the time being.

Actions #16

Updated by Matt Gold over 9 years ago

okay -- cool. Thanks, Ray.

Actions

Also available in: Atom PDF