Feature #25349
closed
Bug #25126: VPAT Initial Report
Display name should be H1 on CV
Added by Boone Gorges 21 days ago.
Updated about 10 hours ago.
Description
One piece of feedback from the VPAT related to the CV Editor:
"The ""education"", ""publications"" and the rest of the headings in that section are marked up as h2 but those are sub-headings of ""RB"" which is marked up as h2 as well. Make sure to make ""RB"" a higher level (H1).
I took a look at bumping the heading level of core/heading in cv-heading-group to 1, but I didn't understand how or whether that would be applied to existing CVs.
Jeremy, could you think about this and see if you can come up with a way forward?
- Target version changed from 2.7.9 to 2.7.10
I have a fix for this in https://github.com/cuny-academic-commons/cac/commit/c18dcc5b5e70f7429cbba7c48d577a7f9edc726d (which is also against the 2.8.x branch, sorry)
It:
- Sets all new CVs to use H1 for the CV owner name.
- Filters the render of existing CVs (via the heading group) to use H1 if they use H2.
- Also fixes an H1/H2 mismatch on the "Welcome to your CV!" page.
This works as a patch for now. We can also write a CLI command to fix the existing CVs in place, but that's a bit riskier.
Another one: the subtitle under owner is an H3, so the flow is now H1 -> H3. Are there any objections to upgrading that as well?
Thanks, Jeremy! Fix looks good. I like the filter approach rather than a search-replace.
Let's go ahead and upgrade the subtitle to an H2.
When you've got these fixed, could you please cherry-pick them back to 2.7.x?
- Status changed from New to Resolved
Also available in: Atom
PDF