Feature #2707
closedRevise Group Invitation Explanatory Text
0%
Description
Question for you:
1. I created a hidden group
2. I added some content to it
3. I thought about inviting some people to it, so I went to "send invites"
4. I typed in names and added people to the list of people to whom invites would go, but my impression is that the invitation would not be sent until I hit the "send invites" button (that, at least, is what the explanatory text indicates)
5. I decided not to invite anyone, so I navigated away from the page (clicked on "forum" in the group nav, I think)
6. When I went back to "sent invites," the people I had added to the list of invitees but had not actually invited were now shown in a list of members who had already been invited.
So, a few questions:
1. Were those invitations actually sent out?
-- if yes, why were they sent out if I didn't click the "send invites" link?
-- if no, why are they shown in that list of members who have already been invited?
Files
Updated by Boone Gorges over 11 years ago
- Status changed from Assigned to Reporter Feedback
Were those invitations actually sent out?
No. They were created in the database, but marked invite_sent = 0. It's only when you click the Send Invites button that invite_sent gets switched to 1, and notifications are sent. Users don't see, and cannot accept, invitations that are marked invite_sent = 0.
if no, why are they shown in that list of members who have already been invited?
They are, for lack of a better term, your "pending" invitations.
Updated by Matt Gold over 11 years ago
- Tracker changed from Support to Feature
- Subject changed from Group Invitation Question to Revise Group Invitation Explanatory Text
- Status changed from Reporter Feedback to Assigned
- Severity set to Low impact
Okay, thanks -- that's good to hear. I think we should adjust the explanatory text, though, to reflect the fact that they are pending and have not been sent.
Updated by Boone Gorges almost 11 years ago
- Category name changed from BuddyPress (misc) to Group Invitations
Updated by Boone Gorges over 10 years ago
- Status changed from Assigned to Reporter Feedback
- Estimated time changed from 0.50 h to 2.00 h
It turns out I was wrong about http://redmine.gc.cuny.edu/issues/2707#note-1. I was looking at the way that BuddyPress handles invitations, forgetting that the Invite Anyone plugin is responsible for this. In fact, the way it actually works is that the Send Invites button does nothing - invitations are sent immediately when selecting a user from the autocomplete dropdown.
This is very odd, and should probably be fixed one way or other. Do you have suggestions on how you think it ought to work? Should I make it work like the interface makes it look like it should work, ie pending invites that are only sent when Send Invites is clicked?
Updated by Matt Gold over 10 years ago
Should I make it work like the interface makes it look like it should work, ie pending invites that are only sent when Send Invites is clicked?
I think so. There are dangers either way -- if you send on checkbox click, invitations could easily be sent accidentally. If you send on clicking the "send button," some people may miss it there and thus be confused. I would err towards the latter solution, since it seems like the former could easily produce lots of unintended/unwanted email.
Updated by Chris Stein over 10 years ago
I agree that they should be sent on clicking the Send button. If people aren't seeing it then maybe there are other visual design changes we can make to improve that.
Updated by Boone Gorges over 10 years ago
- Status changed from Reporter Feedback to Assigned
- Target version changed from 1.6 to 1.7
This has gotten tied up because of some fairly large changes in the way that group invitations work in BuddyPress. I'm afraid there will not be time to make the necessary changes in Invite Anyone for the 1.6 release.
Updated by Boone Gorges about 10 years ago
- Assignee changed from Boone Gorges to Samantha Raddatz
- Target version changed from 1.7 to 1.8
Samantha - Moving this over to you to analyze from a UX point of view.
Updated by Samantha Raddatz about 10 years ago
- File Creating New Group.png Creating New Group.png added
- File Adjusted Invites.jpg Adjusted Invites.jpg added
Interestingly, when first creating a new group myself, I was never presented with a 'Send Invites' button at all (see 'Creating New Group' file attached), so in this spot it's even more confusing. Should I create a separate ticket for this?
Within existing groups, I see what Matt is describing. I agree that not sending invites until clicking on 'Send Invites' is the best option. There's already a lovely pop-up that double-checks that the user would like to leave the page without sending invites.
Moving the order of the fields within this page could also help with confusion. See 'Adjusted Invites' file attached to see a possible re-ordering.
Updated by Boone Gorges about 10 years ago
Interestingly, when first creating a new group myself, I was never presented with a 'Send Invites' button at all (see 'Creating New Group' file attached), so in this spot it's even more confusing. Should I create a separate ticket for this?
Good call. I never noticed this. Please do open a separate ticket - changing this text is an easy fix for 1.7.
Updated by Samantha Raddatz about 10 years ago
- Assignee changed from Samantha Raddatz to Boone Gorges
Tossing this back to Boone– I believe the changes to existing group invites still needs some tweaks.
Updated by Boone Gorges about 10 years ago
Samantha - can you clarify the changes that are necessary? I'm not sure I understand what I should take away from the discussion above.
Updated by Samantha Raddatz over 9 years ago
- File Adjusted Invites.jpg Adjusted Invites.jpg added
I had some layout suggestions for the 'Send Invites' page in existing groups -- see 'Adjusted Invites.jpg' attached.
Other than that, I think this ticket is resolved.
Updated by Boone Gorges over 9 years ago
- Target version changed from 1.8 to 1.9
I'm going to punt this one so that the layout changes can be implemented properly.
Updated by Boone Gorges about 9 years ago
- Status changed from Assigned to Resolved
I've made the suggested layout changes: https://github.com/cuny-academic-commons/cac/commit/96331f1761e2ef0cb5317d2d5c85d8c817765115