Project

General

Profile

Bug #2765

Scrolling/layer issue on admin bar

Added by Matt Gold almost 6 years ago. Updated about 4 years ago.

Status:
Resolved
Priority name:
Normal
Assignee:
Category name:
Toolbar
Target version:
Start date:
2013-08-30
Due date:
% Done:

0%

Estimated time:

Description

On the profile dropdown on the admin bar, when one goes to My Groups, a list of groups pops up to the right of the menue. If one has a long list of groups and one scrolls while the cursor is over that list of groups, the scrolling action affects the background page rather than the dropdown menu.


Related issues

Related to CUNY Academic Commons - Bug #1543: Spacing on "My Groups" DropdownRejected2012-01-13

History

#1 Updated by Boone Gorges almost 6 years ago

  • Category name deleted (BuddyPress (misc))
  • Target version set to 1.6

This is an unresolved issue with the WP admin bar itself. http://core.trac.wordpress.org/ticket/15317

See alse #1480, where I'd previously implemented a multi-column workaround for the issue. It was somewhat clunky. As noted in http://redmine.gc.cuny.edu/issues/2396#note-7, I did not re-implement it for the new admin bar, as it was known to be hacky.

I'll put this in 1.6, with the notes that (a) it does not affect all users, only those with large numbers of groups/blogs, (b) I don't know how to solve the underlying issue, and (c) I would put it in Future Release if that were not frowned upon :)

#2 Updated by Matt Gold almost 6 years ago

okay - thanks, Boone.

#3 Updated by Boone Gorges over 5 years ago

I'd like to revisit this after the WordPress 3.8 upgrade, where some improvements have been made to multi-tiered flyout menus.

#4 Updated by Boone Gorges over 5 years ago

  • Category name set to Toolbar

#5 Updated by Matt Gold over 5 years ago

  • Target version changed from 1.6 to 1.7

#6 Updated by Boone Gorges almost 5 years ago

Just came across this: http://wptavern.com/wordpress-multisite-tip-add-a-search-bar-to-the-my-sites-menu?utm_source=rss&utm_medium=rss&utm_campaign=wordpress-multisite-tip-add-a-search-bar-to-the-my-sites-menu

It's designed for the My Sites menu, but I bet we could implement it and something similar for My Groups. In the absence of a scrolling solution in WP itself, I wonder if this might be promising.

#7 Updated by Matt Gold almost 5 years ago

Sounds like a very useful feature!

#8 Updated by Boone Gorges almost 5 years ago

Dan, you want to have a swing at this? A couple things:

1. Because of customizations to the way the admin bar works on the Commons, this plugin won't work out of the box. You'll have to do some modification (probably just to the JS selector) to get it to work correctly. Our custom menu is under the user menu (the avatar at the upper left) > My Sites
2. Once you've got it working, see if you can do the same thing for [user menu] > My Groups. Bonus points if you can make the same bit of JS do dual-duty for both menus (feel free to add CSS selectors as necessary to make this work)

#9 Updated by Boone Gorges almost 5 years ago

Hi Dan - Circling back around to this ticket. We're looking to have development on 1.7 features done by Oct 3. This issue is non-critical, but it would be really cool to have for this release. Let me know if you think you'll be able to have a look in the next few days.

#10 Updated by Boone Gorges almost 5 years ago

  • Target version changed from 1.7 to 1.8

Moving this to 1.8 for development.

#11 Updated by Boone Gorges over 4 years ago

  • Assignee changed from Boone Gorges to Daniel Jones

Dan, could I ask you to have another look at this? It's a feature that would be cool to include in the 1.8 release, and I don't think it would be overly hard to build, but it's not critical. If you have a chance in the next couple days, could you see whether you think it's feasible to build something in, say, the next three weeks?

#12 Updated by Daniel Jones over 4 years ago

So I tried to handle this with just CSS - https://github.com/cuny-academic-commons/cac/commit/f64bb4f405adc19036e7850b2145778fd7892ab8

I put a max-height on the container for the list and then made it scrollable on the y-axis. Seemed to work so that when I hover over it, it scrolls instead of the whole screen. I tried to put it in admin-bar.css but that wasn't showing up when I loaded the page, so I just put it custom.css. Let me know if I should move it somewhere else or if this solution doesn't work, or if you want me to try and hide or re-style the scrollbar. Thought it was a good cue that it is actually scrollable.

#13 Updated by Boone Gorges over 4 years ago

Thanks, Dan. I'm happy with this solution. Can you apply it to the My Sites dropdown as well please?

#14 Updated by Boone Gorges about 4 years ago

  • Assignee changed from Daniel Jones to Boone Gorges

I'll handle porting this one.

#15 Updated by Boone Gorges about 4 years ago

  • Status changed from Assigned to Resolved

In https://github.com/cuny-academic-commons/cac/commit/f24687038e660c0851080f56d877af32720d77cb I ported the same functionality to the My Sites menu. Works well, I think.

I also moved the styles to our admin-bar.css file. We don't want them to be tied to bp-nelo.

Marking as resolved. Thanks, Dan.!

Also available in: Atom PDF