Project

General

Profile

Bug #2833

Allow silent file deletions

Added by Matt Gold almost 8 years ago. Updated over 7 years ago.

Status:
Resolved
Priority name:
Normal
Assignee:
Category name:
Group Files
Target version:
Start date:
2013-10-16
Due date:
% Done:

0%

Estimated time:
2.00 h

Description

We now allow "silent" file uploads; I think we should give members the option to delete files silently, too -- just saw someone delete 7 files and thus send out 7 notifications.

Right now, we have a confirmation pop-up asking people whether they really want to delete. We'd have to rethink that a bit to allow a checkbox for silent deletions. Assigning initially to Chris for UX thoughts.


Related issues

Related to CUNY Academic Commons - Feature #2192: Allow members to replace filesResolved2012-10-13

Related to CUNY Academic Commons - Bug #3006: Remove escaping from file descriptionsResolved2014-01-31

History

#1 Updated by Matt Gold almost 8 years ago

  • Subject changed from Allow silent files deletions to Allow silent file deletions

#2 Updated by Boone Gorges almost 8 years ago

  • Target version set to 1.6

#3 Updated by Boone Gorges over 7 years ago

  • Assignee changed from Chris Stein to Boone Gorges
  • Estimated time set to 2.00 h

Reassigning to myself. I think we can do a first pass at this without significant UX work up front. Let's do it along with #2192, as enhancements to our existing Files system.

#4 Updated by Matt Gold over 7 years ago

Cool.

#5 Updated by Boone Gorges over 7 years ago

  • Category name changed from BuddyPress (misc) to Group Files

#6 Updated by Boone Gorges over 7 years ago

  • Status changed from Assigned to Reporter Feedback

Thinking more about this. Is there every reason to have a non silent file deletion? Do file deletion notifications have any purpose? If we just eliminate them altogether, it'll eliminate another awkward piece of UI.

#7 Updated by Matt Gold over 7 years ago

I've been thinking about this a bit in relation to the replace file ticket ( http://redmine.gc.cuny.edu/issues/2192 )

What worries me a bit is that if any user in a group can delete or replace files created by any other user, and if no notification is generated, a member can delete/replace files without the knowledge of the person who originally uploaded them. I can see some possibly nefarious results of that if someone has malicious intentions.

One thing I'm wondering about: is it possible to create a record of some kind -- an activity item or some notation on the file itself that indicates the change -- without also generating an email notification? I guess I'm thinking that there should ultimately be some way for people to have a kind of "history" of file actions, which would make me feel better, for instance, about either making file deletions/replacements silent as a default option or just as a default.

#8 Updated by Boone Gorges over 7 years ago

It's possible to change the definition of "silent" so that activity items remain but email notifications are not sent.

A separate system for keeping track of file changes is much more complex.

#9 Updated by Matt Gold over 7 years ago

It's possible to change the definition of "silent" so that activity items remain but email notifications are not sent.

I like that idea, since the "silent" feature was really meant to prevent annoying/cluttering emails.

> A separate system for keeping track of file changes is much more complex.

Okay. I'll add a ticket and put it in future release.

#10 Updated by Boone Gorges over 7 years ago

  • Status changed from Reporter Feedback to Testing Required

In https://github.com/castiron/cac/commit/ec4e97bf779a461ea7f9113a3b7e9fe87a6b91f8 I make the following changes:

- "Silent" now means that email notifications are not sent, but activity items continue to be created
- There is now an option for "silent delete" when you delete a document. The toggle is a checkbox in the dialog box.

Ready to test on openlabdev.org.

#11 Updated by Matt Gold over 7 years ago

  • Status changed from Testing Required to Assigned

We've tested and this is good to go.

#12 Updated by Boone Gorges over 7 years ago

  • Status changed from Assigned to Resolved

Feel free to mark resolved when you're satisfied with this kind of thing.

#13 Updated by Matt Gold over 7 years ago

Okay - just didn't know whether you needed to make a final commit before doing so.

Also available in: Atom PDF