Project

General

Profile

Feature #2192

Allow members to replace files

Added by Matt Gold almost 9 years ago. Updated over 7 years ago.

Status:
Resolved
Priority name:
Normal
Assignee:
Category name:
Group Files
Target version:
Start date:
2012-10-13
Due date:
% Done:

0%

Estimated time:
2.00 h

Description

I know that our files/docs interface is changing, but it would be neat if group members could replace files that had already been uploaded instead of deleting them and uploading new files. This would allow new versions of files to be shared. Scribd has a nice UI/process for this.


Related issues

Related to CUNY Academic Commons - Bug #2833: Allow silent file deletionsResolved2013-10-16

Related to CUNY Academic Commons - Bug #3006: Remove escaping from file descriptionsResolved2014-01-31

Blocked by CUNY Academic Commons - Feature #621: BuddyPress Docs uploadsRejected2011-02-25

History

#1 Updated by Boone Gorges almost 9 years ago

  • Target version changed from 1.5 to Future release

This'd require an extensive rewrite of how the file stuff works. Let's think about this as a feature for the future replacement of our current Files tool.

#2 Updated by Matt Gold almost 9 years ago

okay, but should we perhaps consider this in connection with http://redmine.gc.cuny.edu/issues/621 for 1.6?

#3 Updated by Boone Gorges almost 9 years ago

  • Target version changed from Future release to 1.6

OK. No need for a "but".

#4 Updated by Boone Gorges over 7 years ago

  • Estimated time set to 2.00 h

Instead of waiting for some mythical replacement :) let's just implement this on top of what we already have. It will be a good companion to #2833

#5 Updated by Matt Gold over 7 years ago

Great. Glad we're working on this for 1.6 -- good to have these upgrades to group functionalities.

#6 Updated by Boone Gorges over 7 years ago

  • Category name changed from BuddyPress (misc) to Group Files

#7 Updated by Boone Gorges over 7 years ago

  • Status changed from Assigned to Testing Required

First pass is ready for testing on cdev. Look for the "replace" links next to existing files.

https://github.com/castiron/cac/commit/4937c31c1a6cf2658cce909562eb8655d316baa1

#8 Updated by Matt Gold over 7 years ago

Only tested a docx file, but looks great to me. More testing should be done for other file types. This is great.

#9 Updated by Matt Gold over 7 years ago

One question -- can any member of a group replace any file?

I also wondered whether "silent upload" should be checked by default on replace files, on the logic that if you are replacing your own file, you may not want to bother the whole group with a notification, but I can see reasons why one might not want to go that way (perhaps it's more important to have the default lean towards a situation where people would be notified of any changes . . . .status quo is fine with me.

#10 Updated by Boone Gorges over 7 years ago

  • Status changed from Testing Required to Reporter Feedback

One question -- can any member of a group replace any file?

Yes.

I also wondered whether "silent upload" should be checked by default on replace files

This seems fine to me. Let me know if you want it implemented.

#11 Updated by Matt Gold over 7 years ago

This sounds good to me as we change the definition of "silent" per this ticket - http://redmine.gc.cuny.edu/issues/2833

#12 Updated by Chris Stein over 7 years ago

File Activity Notifications
I have a couple of questions and comments.
On the question of whether silent upload should be default on file replacement, I would suggest we stick with the same behavior as for file uploads (not checked by default). A file replacement can be a big deal, especially as Matt noted if you are replacing someone else's file, so I don't have a problem notifying people. If the user doesn't want to notify people she can always check the Silent upload button. t have a couple of small visual design changes listed below that may help increase visibility.

In Recent Group Activity on the home screen I noticed that an activity was added when the file was replaced but there is no activity when the file is added.
Can we add an activity item when a new file is uploaded?

When you replace a file the message starts:
username modified filename in

Is it relatively simple to change the text to the following ?
username replaced the file filename with a new version in

Visual Design Changes
In the attached screenshot I made some changes to the Silent upload label. I
  • made it bold
  • added an nbsp in front of it
  • added a space after it

These changes are designed to make the feature stand out a bit more. I can move this to another ticket, just adding it here since it is semi-related.

Cancel Functionality
If this warrants another ticket, let me know. I'd like to change the functionality of the Cancel. Right now there is a Cancel link in the "Replace existing file" line. When it is clicked it removes that line effectively turning the form into a straight new file upload.

Instead I propose removing the link and adding a Cancel button underneath the Submit button (see screenshot). This would cancel the upload new file form entirely and take the user back to just seeing the file list. It would work the same both for when a new file is being uploaded and when a file is being replaced.

#13 Updated by Boone Gorges over 7 years ago

Is it relatively simple to change the text to the following ?
username replaced the file filename with a new version in

No, because from the point of view of the plugin, it's an edit - I'm fooling it. But, I'll see what I can do.

Instead I propose removing the link and adding a Cancel button underneath the Submit button (see screenshot). This would cancel the upload new file form entirely and take the user back to just seeing the file list. It would work the same both for when a new file is being uploaded and when a file is being replaced.

This change seems fine to me. Having it appear as a button exactly like Submit seems visually odd to me, as does putting it below rather than next to Submit. I'd suggest having it as a plaintext link, maybe in red, next to Submit. But the functionality change seems reasonable.

#14 Updated by Boone Gorges over 7 years ago

  • Status changed from Reporter Feedback to Testing Required

In https://github.com/castiron/cac/commit/baabfa7a38c86b915b34390899cacdd029dbd2e0 I made the following changes:

- Visual style changes in accordance with Chris's suggestions
- Changed language of replacement activity item to what Chris suggested
- Moved the Cancel link and made it apply to the entire upload process, as Chris suggested. I went with my suggested positioning/styling.

#15 Updated by Matt Gold over 7 years ago

Worked perfectly in my test. Thank you!

#16 Updated by Matt Gold over 7 years ago

  • Status changed from Testing Required to Assigned

Tested by Comm team. Good to go!

#17 Updated by Boone Gorges over 7 years ago

  • Status changed from Assigned to Resolved

Also available in: Atom PDF