Project

General

Profile

Bug #2879

Adminbar JS is conflicting on some blogs

Added by Dominic Giglio over 7 years ago. Updated over 7 years ago.

Status:
Resolved
Priority name:
Normal
Category name:
WordPress (misc)
Target version:
Start date:
2013-11-08
Due date:
% Done:

0%

Estimated time:

Description

The adminbar JS file is either being loaded twice or is conflicting with another JS file being loaded by specific blogs preventing the adminbar from functioning correctly. I'm going to investigate where this conflict is coming from and how to correct it.

A specific example can be seen on CUNYPie:

http://cunypie.commons.gc.cuny.edu

History

#1 Updated by Raymond Hoh over 7 years ago

The "wpng-calendar" plugin is loading its own version of jQuery, which is a no-no!

Two courses of action:
  • Patch wpng-calendar to use WP's version of jQuery and notify the plugin authors. (Also check if there is an update for the plugin and see if this is addressed in a newer version.)
  • Disable the plugin and use a different calendar plugin on CUNYPie.

#2 Updated by Matt Gold over 7 years ago

we can disable that calendar plugin on CUNYPie, as we're not using it, but I wonder what other sites are also using that plugin . . . .

#3 Updated by Matt Gold over 7 years ago

deactivated on cunypie. Dom, can you retest?

And thanks, Ray!!

#4 Updated by Dominic Giglio over 7 years ago

Looks good on my end.

I'm pretty sure Boone and I blacklisted the enabling of this plugin for this very reason. We left the plugin enabled on any site where it was already running so we wouldn't disrupt anyone's current setup, but no one can enable it going forward if they weren't already "grandfathered in."

#5 Updated by Boone Gorges over 7 years ago

  • Status changed from New to Assigned
  • Target version changed from Not tracked to 1.5.8
$ git log wp-content/plugins/wpng-calendar/
commit a86d7a16d7bec23b019d3faed503eaadc490d6ed
Author: Boone Gorges <boonebgorges@gmail.com>
Date:   Tue Jan 10 18:19:02 2012 -0500

    Fixes some PHP notices

commit 92a33878c47d73173bd15ec6b99834e211ba3f13
Author: Boone Gorges <boonebgorges@gmail.com>
Date:   Tue Jan 4 18:15:20 2011 -0500

    Fixes widget title markup in Google Calendar widget. Fixes #509

commit b92399fd00d9d3cdbbf2b1356139ef540a0f9654
Author: Zach Davis <zach@castironcoding.com>
Date:   Fri May 14 17:52:24 2010 -0500

    initial commit

Doesn't look like wpng-calendar is being maintained, so I'd say let's just go ahead and make the change right in the plugin. Dom, can you take care of this? Remove their own registering/enqueuing of jquery, and then make sure that jquery is registered correctly as a dependency for their other scripts. Then, please feel free to send a .diff patch to the author, if you can find their info (though don't hold your breath for it to be implemented).

#6 Updated by Dominic Giglio over 7 years ago

Ya, I'll take of it. This will fix any current blogs that still have it enabled and as I said above, no one else can enable it going forward.

#7 Updated by Matt Gold over 7 years ago

Thanks, guys -- and look at us, knocking off the most serious issue registered in the usability report like it was nothing.

#8 Updated by Boone Gorges over 7 years ago

  • Target version changed from 1.5.8 to 1.5.9

#9 Updated by Boone Gorges over 7 years ago

  • Status changed from Assigned to Resolved

Looks like this should have been marked resolved last time around.

#10 Updated by Boone Gorges over 7 years ago

  • Target version changed from 1.5.9 to 1.5.10

Also available in: Atom PDF