Bug #3044
closedFormatting issues in profile rich text editor
0%
Description
(Copied from http://redmine.gc.cuny.edu/issues/2736#note-25)
What's happening is that the text in the top field is aligned center and can't get aligned flush left. I think I did this by clicking a whole range of formatting buttons -- ordered list, bulleted list, then header 1, then justify left/right/center, then p. Now the text won't become flush left and it looks like some formatting code is spilling over to the next field. You can see this live on the Text Student account on cdev.
See that ticket for screenshots.
Updated by Boone Gorges about 10 years ago
Matt, I have a feeling that there are two separate issues here: the broken buttons in the first field after messing with them a lot, and the "bleedover" formatting in the Publications field.
I'll look into the first one.
For the second one, my guess is that you copied and pasted this content from somewhere else on the web. Can you please share details about this?
Updated by Boone Gorges about 10 years ago
I wasn't able to reproduce either bug exactly, but I have a feeling that they both may result from the cutting-and-pasting of invalid/unsupported markup into the fields. In https://github.com/cuny-academic-commons/cac-advanced-profiles/commit/da6db055ec946633e2674b91479136a96561d048, I put a filter in place that should prevent this kind of content from getting saved in the first place.
Updated by Matt Gold about 10 years ago
Okay.
Issue 1: I did not cut/paste anything from anywhere, just played around with different formatting buttons.
Issue 2: I did cut/paste, but I did not see that extra formatting when I first saved upon doing so; it was only afterwards, after playing with buttons per Issue 1, that I noticed the error.
It sounds like you've put in a reasonable fix.
Updated by Boone Gorges about 10 years ago
- Status changed from Assigned to Reporter Feedback
Thanks. I don't see any evidence that issues in the first box could affect the second box. They may be adjacent on the page, but they are unrelated when it comes to markup and the save routines. I think it may be a coincidence that they both got messed up at the same time.
It's possible that there will continue to be issues with the formatter. I'm using an external library, and it's not perfect. In particular, if you go nesting lots of header and paragraph tags, it gets kinda hard to edit them out, because you have to highlight exactly the right text. If we find that there are widespread reports of issues with odd formatting, it may be worth investing time into improving the library or finding an alternative. But for now, I suggest that we close this ticket, opening a separate item if we find that others reproduce similar problems in the future.
Updated by Matt Gold about 10 years ago
Okay. I wonder if one potential solution would be to add a "clear formatting" button for each text box?
Updated by Boone Gorges about 10 years ago
I don't know about "solution", but it's a potential workaround. If this is important to you, let's open a separate ticket for it, so I can provide proper estimates.
Updated by Boone Gorges about 10 years ago
- Status changed from Reporter Feedback to Assigned
- Target version changed from 1.6 to 1.7
Let's reconsider for 1.7.
Updated by Boone Gorges over 9 years ago
- Status changed from Assigned to Resolved
Since it looks like these specific formatting issues have not come up again, and since there's been some progress on the related #3044, I'm going to close this ticket as Resolved. If specific issues arise in the future, let's consider in a new ticket.