Project

General

Profile

Feature #3049

Toolbar position improvements

Added by Boone Gorges over 7 years ago. Updated over 7 years ago.

Status:
Resolved
Priority name:
Normal
Assignee:
Category name:
Public Portfolio
Target version:
Start date:
2014-02-19
Due date:
% Done:

0%

Estimated time:
3.00 h

Description

http://redmine.gc.cuny.edu/issues/2736#note-28

Chris said:

Boone, I think you may have addressed this but adding my observations in case there are any differences. I found that the JS set the width of the div.halootoolbar to 558px. This caused the h3 button to break to the next line for me. If it was changed to 565px then all was fine.

I also found if I added a margin-top to the div that contains the edit area then the buttons would sit on top of it which is where I expected them See Margin-Top-Buttons.png (in next post, hit submit by accident and can't add image).
I added 80px but could be a little less:
#cacap-edit .cacap-click-to-edit.editing {
margin-bottom: 50px;
margin-top: 80px;
}

Toolbar-at-top.png (18.9 KB) Toolbar-at-top.png Chris Stein, 2014-02-19 06:25 PM

History

#1 Updated by Boone Gorges over 7 years ago

  • Status changed from Assigned to Reporter Feedback

Thanks for this, Chris. Unfortunately it is not as simple as adding a style rule, because of the way the editor works. However, I will take a closer look. Can you please attach the screenshot that you were planning to post? You never did so on the #2736

Please also share details about your browser/OS setup. On my configuration, I'm not seeing the items break into a second row.

#2 Updated by Boone Gorges over 7 years ago

  • Status changed from Reporter Feedback to Testing Required

I made some mods to the way the toolbar is loaded and styled. Ready to test on cdev.

#3 Updated by Matt Gold over 7 years ago

Thanks, Boone. I don't think that the new position works well because people will expect it to be on top of the text box. This is particularly a problem with a long vertical text box, since it's possible for the formatting bar to appear below the fold. I think we should see if we can get it working at the top if possible.

#4 Updated by Boone Gorges over 7 years ago

I think we should see if we can get it working at the top if possible.

Can you explain this further? The new positioning has it "working at the top". Maybe we're seeing something different? Please do a hard refresh, and then post a screenshot of what you're seeing, along with OS/browser details.

#5 Updated by Chris Stein over 7 years ago

I see it at the top now. The positioning looks good to me. Attaching screenshot just in case there is still confusion.

As long as you're straight with this too Matt, I'm OK marking resolved.

#6 Updated by Matt Gold over 7 years ago

  • Status changed from Testing Required to Resolved

Yup -- looks great. Thanks, Boone!

Also available in: Atom PDF