CUNY Academic Commons

Leah - Thanks so much for reporting this.

This is going to be a hard problem to solve. I was planning on at least hiding the plugin for new users, but it turns out that we have (and have long had) the plugin network activated, which means there are no "new users". I can't network deactivate it without being able to activate it on the blogs where it's needed; but to know that I need to find some way of reliably determining who's currently using it. Add to this the fact that Jetpack's CSS tools don't necessarily work without connecting to wordpress.com - which makes me very reluctant to rely on it as the sole alternative - and we have sort of a complex issue.

It might be that, in the short term, the easist fix is to fix the plugin and maintain our own fork. Leah, if you get a few moments, would you mind elaborating a bit on the changes you attempted to make, and the ways in which they didn't seem to show up? If I could reproduce the issues locally, I might find that a fix for the plugin is fairly straightforward.

Thanks, Leah - Time got away from me this time around, so I'm going to try to look at this for the next release.

Leah, thanks for your patience as I sort this out. After some research, I ended up rewriting much of the plugin logic, and going with a separate sanitization library (the same one used in Jetpack, in fact). This means that selectors like the ones you're trying to use here will now work, and we here at the Commons won't have to go through the process of migrating everyone away from this otherwise working plugin.

Relevant changeset (in our private repo, sorry) is https://github.com/castiron/cac/commit/9245edfb98685d3680359a1116f7252480c5e106

After the 1.6.5 release, scheduled for June 1, I'll update this ticket to let you know that the changes have been deployed and are available for testing. At that time, you'll need to resave a clean copy of your custom CSS, at which point it should be properly sanitized and ought to work correctly. Until then, I'm marking this ticket resolved.