CUNY Academic Commons

More specific reporting on the error encountered from the comment thread :

Turned on error reporting via Comment 72 by Mark, and get this error:

Fatal error: Cannot access protected property WebRequest::$data in /Users/Frankly/Sites/dip.youthstudies.eu/wiki/extensions/LogoutLoginWP/LogoutLoginWP.php on line 29

Line 29 is this:

if($redirectTo = $wgRequest->data['redirect_to'])

I think I found the solution via other MediaWiki extensions who had similar problems, apparently because of a change in MW 1.16 through which a public field became protected (source).

Changing the code in line 29 to this solved all my problems and all works beautifully now:

Nicely done, Andreas.

When I first saw that snippet of code I wondered if the value assignment was intentional or if it was supposed to be an equality check. I assume it's the former, and that this is a case of my own desire for brief and clever code run amok. Readability would be improved by replacing line 29 with:

$redirectTo = $wgRequest->getVal('redirect_to');
if($redirectTo) {

I or someone else at CIC will do that this week.

Lucas

Works as smoothly! Lovely :)