Bug #3705: Filtering Crossover on MyCommons and My Activity - CUNY Academic Commons - CUNY Graduate Center - Project Tracking System

Actions

Copy link

Bug #3705

closed

Filtering Crossover on MyCommons and My Activity

Added by Chris Stein almost 10 years ago. Updated almost 10 years ago.

Status:

Resolved

Priority name:

Normal

Assignee:

Raymond Hoh

Category name:

My Commons

Target version:

1.7.6

Start date:

2014-12-10

Due date:

% Done:

Estimated time:

Deployment actions:

Description

There are a couple of issues

in My Activity when you first choose a filter by the Show dropdown the formatting of the page gets messed up
The filter you choose effects the My Commons page

To reproduce

Go to My Activity
Choose a filter, like Posts (2-FilterActivity.png)
The layout will get messed up (3-LayoutIssue.png)
Hard refresh fixes layout issue (4-AfterRefresh.png)
Go to My Commons and pick filter that uses what you chose in step 2, showing Groups in 5-MyCommons-filterBleed.png. It will be filtered with the same one chose in step 2
If you go back to My Activity and choose Everything under the filter it will have the same layout issue fixed by hard refresh but also
if you go back to My Commons and look at the same filter from step 5 you will see it now shows everything again

Files

Download all files

2-FilterActivity.png (62.8 KB) 2-FilterActivity.png		Chris Stein, 2014-12-10 05:47 AM
3-LayoutIssue.png (430 KB) 3-LayoutIssue.png		Chris Stein, 2014-12-10 05:47 AM
4-AfterRefresh.png (139 KB) 4-AfterRefresh.png		Chris Stein, 2014-12-10 05:47 AM
5-MyCommons-filterBleed.png (132 KB) 5-MyCommons-filterBleed.png		Chris Stein, 2014-12-10 05:47 AM

Actions

Copy link

Updated by Raymond Hoh almost 10 years ago

Thanks for the detailed steps and the screenshots, Chris! Definitely helped in duplicating the issue.

For image 5, this should be fixed as of commit 4461f47.

For image 3, the problem is with the div.activity selector on the CAC Advanced Profiles header (the header-top.php template). If we rename the element for div.activity to something else like span.activity or p.activity, this will fix the problem. However, the div.activity element is not even visible; it's currently hidden with this CSS - display:none.

So my recommendation would be to remove the <div class="activity"> block from the header-top.php template entirely when on a BP profile page. Boone, I've gone ahead and committed this in the CAC Advanced Profiles repo.

If you'd rather go with a different approach (like renaming the element), Boone, feel free to revert the commit. I also haven't pinned this CACAP commit to 1.7.x branch yet. Let me know what you think.

Actions

Copy link