Project

General

Profile

Actions

Feature #3941

closed

Group forums -- Edited comment notifications

Added by Matt Gold over 7 years ago. Updated over 7 years ago.

Status:
Resolved
Priority name:
Normal
Assignee:
Daniel Jones
Category name:
Email Notifications
Target version:
Start date:
2015-03-21
Due date:
% Done:

0%

Estimated time:
Deployment actions:

Description

A member of one of my groups posted a comment on a forum in response to a post. He then saw an error in his comment, so he clicked "edit," fixed the error, and clicked save.

This produced two email notifications in a short amount of time -- at least to my account (not sure whether non-admins received them, too).

Both notifications came with the same wording -- [user] replied to the topic [topic name] in the forum [forum topic name]

My suggestions:

If an edit of a forum post triggers a notification, it should have a different notification message, e.g.c "[user] edited a reply to [forum topic name]

or

There should not be a second notification if, say, it is posted within a given amount of time from the original post

FYI, here is the post in question (SF's comment)

Actions #1

Updated by Boone Gorges over 7 years ago

  • Assignee changed from Boone Gorges to Daniel Jones
  • Target version set to 1.8

Dan, will you look at this? I would suggest getting a checkout of bbPress (git://bbpress.git.wordpress.org) and writing a version of Matt's first suggestion (User edited a reply...) as a patch for bbPress. Once you've got a patch written, I can walk you through submitting it to bbPress.

Actions #2

Updated by Raymond Hoh over 7 years ago

I added a patch on bbPress Trac awhile ago about this bug:
https://bbpress.trac.wordpress.org/ticket/2690

It should be as easy as applying my patch. Do take note of what I mention here.

If we don't want to patch bbPress directly, we can go with a version of a fix I placed in CBOX.

Actions #3

Updated by Boone Gorges over 7 years ago

  • Target version changed from 1.8 to 1.7.17

Oof, I didn't realize this was the same issue. Let's just go with the bbPress hotfix. Dan, can you please take care of that in the 1.7.x branch?

Actions #4

Updated by Daniel Jones over 7 years ago

Sorry running into an issue where I can't find the equivalent to CBOX's includes/frontend-bbpress.php in the CAC files. Is there a place where we keep these kinds of modifications to bbpress in CAC already? Should I apply the patch that Ray linked to to bbpress directly instead?

Actions #5

Updated by Boone Gorges over 7 years ago

We don't have a frontend-bbpress.php equivalent. Please just apply the bbPress hotfix.

Actions #7

Updated by Boone Gorges over 7 years ago

  • Target version changed from 1.7.17 to 1.7.18
Actions #8

Updated by Boone Gorges over 7 years ago

  • Target version changed from 1.7.18 to 1.7.19
Actions #9

Updated by Boone Gorges over 7 years ago

  • Target version changed from 1.7.19 to 1.7.20
Actions #10

Updated by Boone Gorges over 7 years ago

  • Target version changed from 1.7.20 to 1.7.21
Actions #11

Updated by Boone Gorges over 7 years ago

  • Target version changed from 1.7.21 to 1.8.1
Actions #12

Updated by Daniel Jones over 7 years ago

Just wanted to check on this - did my application of the hotfix work?

Actions #13

Updated by Boone Gorges over 7 years ago

  • Status changed from Assigned to Resolved

I haven't heard anything, so I'm assuming yes. Let's mark this resolved.

Actions

Also available in: Atom PDF